feat(credential-groups): add personal MCP OAuth connections #29814
TheodoreSpeaksci.yml
on: pull_request
Detect Version
Migrate Dev DB
/
Apply Database Migrations
Detect Desktop Changes
Matrix: Build AMD64
Matrix: Build ARM64 (GHCR Only)
Test and Build
/
Lint and Test
42s
Test and Build
/
Test (shard 2)
2m 9s
Test and Build
/
Build App
2m 23s
Check Docs Changes
Matrix: Build Dev ECR
Deploy Trigger.dev (Dev)
0s
Matrix: Create GHCR Manifests
Process Docs
/
Process Documentation Embeddings
Prune Desktop Prereleases
Desktop Release
/
Build, Sign, Notarize
Annotations
9 errors and 15 warnings
|
Test and Build / Lint and Test
Process completed with exit code 1.
|
|
check:openapi
audit failed — see the group above
|
|
scripts/openapi/documents.test.ts > generated OpenAPI documents > publishes Agent tools as named integration, custom, and MCP schemas:
scripts/openapi/documents.test.ts#L331
AssertionError: expected [ …(4) ] to deeply equal [ …(3) ]
- Expected
+ Received
@@ -6,6 +6,9 @@
"$ref": "#/components/schemas/AgentCustomTool",
},
{
"$ref": "#/components/schemas/AgentMcpTool",
},
+ {
+ "$ref": "#/components/schemas/AgentMcpServerAdvanced",
+ },
]
❯ scripts/openapi/documents.test.ts:331:31
|
|
Test and Build / Lint and Test
Process completed with exit code 1.
|
|
Test and Build / Test (shard 2)
Process completed with exit code 1.
|
|
lib/internal/mcp/execute-tool.test.ts > executeMcpTool > parses direct block arguments and invokes the authorized use case:
apps/sim/lib/internal/mcp/execute-tool.test.ts#L93
AssertionError: expected "vi.fn()" to be called with arguments: [ { context: { …(5) }, …(1) } ]
Received:
1st vi.fn() call:
@@ -22,7 +22,10 @@
],
"userId": "user-1",
"workflowId": "workflow-1",
"workspaceId": "workspace-1",
},
+ "resourceScope": {
+ "mcpServerId": "mcp-server",
+ },
},
]
Number of calls: 1
❯ lib/internal/mcp/execute-tool.test.ts:93:35
|
|
lib/credentials/application/credential-crud.test.ts > personal-credential capability > creates the personal secret when no group withholds it:
apps/sim/lib/credentials/application/credential-crud.ts#L248
Error: [vitest] No "requireOrdinaryCredentialType" export is defined on the "@/lib/credentials/access" mock. Did you forget to return it from "vi.mock"?
If you need to partially mock a module, you can use "importOriginal" helper inside:
vi.mock(import("@/lib/credentials/access"), async (importOriginal) => {
const actual = await importOriginal()
return {
...actual,
// your mocked methods
}
})
❯ Object.afterSuccess lib/credentials/application/credential-crud.ts:248:26
❯ Object.execute lib/core/application/authorized-workspace-use-case.ts:211:24
❯ lib/credentials/application/credential-crud.test.ts:403:20
|
|
lib/credentials/application/credential-crud.test.ts > personal-credential capability > still creates a workspace-shared secret under the same restriction:
apps/sim/lib/credentials/application/credential-crud.ts#L248
Error: [vitest] No "requireOrdinaryCredentialType" export is defined on the "@/lib/credentials/access" mock. Did you forget to return it from "vi.mock"?
If you need to partially mock a module, you can use "importOriginal" helper inside:
vi.mock(import("@/lib/credentials/access"), async (importOriginal) => {
const actual = await importOriginal()
return {
...actual,
// your mocked methods
}
})
❯ Object.afterSuccess lib/credentials/application/credential-crud.ts:248:26
❯ Object.execute lib/core/application/authorized-workspace-use-case.ts:211:24
❯ lib/credentials/application/credential-crud.test.ts:379:20
|
|
Test and Build / Test (shard 2)
@sim/app#test: command (/home/runner/_work/sim/sim/apps/sim) /home/runner/.bun/bin/bun run test exited (1)
|
|
Test and Build / Lint and Test
Skipping sticky disk commit due to previous step failures
|
|
Test and Build / Lint and Test
Found 2 failed/cancelled steps in previous workflow steps
|
|
Test and Build / Lint and Test
Skipping sticky disk commit due to previous step failures
|
|
Test and Build / Lint and Test
Found 2 failed/cancelled steps in previous workflow steps
|
|
Test and Build / Lint and Test
Skipping sticky disk commit due to previous step failures
|
|
Test and Build / Lint and Test
Found 2 failed/cancelled steps in previous workflow steps
|
|
Test and Build / Test (shard 2)
Skipping sticky disk commit due to previous step failures
|
|
Test and Build / Test (shard 2)
- Step: unknown (failed)
|
|
Test and Build / Test (shard 2)
Found 2 failed/cancelled steps in previous workflow steps
|
|
Test and Build / Test (shard 2)
Skipping sticky disk commit due to previous step failures
|
|
Test and Build / Test (shard 2)
- Step: unknown (failed)
|
|
Test and Build / Test (shard 2)
Found 2 failed/cancelled steps in previous workflow steps
|
|
Test and Build / Test (shard 2)
Skipping sticky disk commit due to previous step failures
|
|
Test and Build / Test (shard 2)
- Step: unknown (failed)
|
|
Test and Build / Test (shard 2)
Found 2 failed/cancelled steps in previous workflow steps
|