feat(credential-groups): add personal MCP OAuth connections - #7353
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThe PR adds invitee-specific OAuth connections for MCP servers in Credential Groups and integrates those managed connections into workflow authoring and execution.
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains in the eligible follow-up-review scope. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/app/api/mcp/oauth/callback/route.ts | Adds a sessionless, rate-limited callback path for Credential Group managed MCP OAuth attempts. |
| apps/sim/lib/mcp/application/execute-managed-tool.ts | Executes managed MCP tools through the authorized Credential Group policy boundary and versioned token persistence. |
| apps/sim/lib/credential-groups/application/public-enrollment.ts | Coordinates public enrollment reads and the start and completion of invitee MCP OAuth. |
| apps/sim/lib/mcp/orchestration/server-lifecycle.ts | Extends MCP server lifecycle handling to retire managed connections and release Credential Group assignments. |
| packages/db/migrations/0315_credential_group_managed_mcp.sql | Introduces the persistent relationships needed for Credential Group managed MCP connections. |
| packages/db/migrations/0316_credential_group_managed_mcp_constraints.sql | Adds relational constraints for managed MCP assignments and credential lifecycle. |
| packages/db/migrations/0317_managed_mcp_external_identity.sql | Adds external identity metadata for managed MCP connections. |
| packages/db/schema.ts | Aligns the Drizzle schema with managed MCP assignment, ownership, and external identity records. |
Sequence Diagram
sequenceDiagram
participant Admin as Workspace admin
participant Invitee
participant Enrollment as Enrollment API
participant Provider as MCP OAuth provider
participant DB as Managed connection store
participant Runtime as Workflow runtime
Admin->>Enrollment: Assign OAuth MCP server to Credential Group
Invitee->>Enrollment: Start OAuth from invitation
Enrollment->>Provider: Redirect with scoped authorization state
Provider->>Enrollment: OAuth callback
Enrollment->>DB: Store invitee-specific managed connection
Runtime->>DB: Resolve connection under group workflow policy
Runtime->>Provider: Execute MCP tool
Provider-->>Runtime: Tool result
Reviews (3): Last reviewed commit: "fix(credential-groups): harden managed M..." | Re-trigger Greptile
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 75 files
Heads up: you’re close to your included review allowance. Set a flex budget so reviews don’t pause.
Re-trigger cubic
Collaborator
Author
Collaborator
Author
TheodoreSpeaks
force-pushed
the
feat/api-key-cred-group
branch
from
September 1, 2026 23:44
7d7b14b to
66c191f
Compare
…group # Conflicts: # apps/sim/lib/credential-groups/application/public-enrollment.test.ts
…group # Conflicts: # packages/db/migrations/meta/0317_snapshot.json # packages/db/migrations/meta/_journal.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Checklist