feat(emails): add sub-processor change notification template - #6820
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview The body covers how to object (mailto and deadline), a link to the public sub-processor list, and an optional subscription preferences link; standard unsubscribe is disabled for this notice type. Wiring matches other notification templates: exports from the notifications barrel, Reviewed by Cursor Bugbot for commit 72606dc. Configure here. |
Greptile SummaryAdds a customer-facing sub-processor change notification and integrates it with the shared email rendering and subject infrastructure.
Confidence Score: 5/5The PR appears safe to merge. The previously reported recipient-action issue is fixed at the current head, and no blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/components/emails/notifications/subprocessor-change-email.tsx | Adds the notification template and fully addresses the prior recipient-action issue with explicit email and preference links. |
| apps/sim/components/emails/render-notifications.test.ts | Adds render-level coverage for notice content, multiple sub-processors, actionable links, and optional subscription settings. |
| apps/sim/components/emails/render.ts | Exposes the new notification through the shared rendering layer. |
| apps/sim/components/emails/subjects.ts | Registers the notification type and its branded subject line. |
| apps/sim/components/emails/notifications/index.ts | Exports the new template and its public change types. |
Reviews (2): Last reviewed commit: "improvement(emails): link the objection ..." | Re-trigger Greptile
|
@cursor review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 72606dc. Configure here.
| If you object to this change, reply to this email or write to{' '} | ||
| <Link href={`mailto:${objectionEmail}`} style={baseStyles.link}> | ||
| {objectionEmail} | ||
| </Link>{' '} |
There was a problem hiding this comment.
Objection mailto opens blank tab
Medium Severity
The objection address is rendered with react-email's Link, which defaults to target="_blank". For a mailto: href that opens a blank tab next to the compose window in most webmail clients. The shared footer already documents this and uses a raw <a> for support mailto links instead.
Reviewed by Cursor Bugbot for commit 72606dc. Configure here.


Summary
Type of Change
Testing
Render tests added under
components/emails;bun run lint,bun run check:audits, andtype-checkpass.Checklist