Skip to content

feat(emails): add sub-processor change notification template - #6820

Merged
waleedlatif1 merged 2 commits into
stagingfrom
feat/subprocessor-change-email
Aug 18, 2026
Merged

feat(emails): add sub-processor change notification template#6820
waleedlatif1 merged 2 commits into
stagingfrom
feat/subprocessor-change-email

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Adds a customer-facing email template for announcing a sub-processor change, with the change details, effective date, and how to raise an objection
  • Wires it through the shared render/subject layer like every other template

Type of Change

  • New feature

Testing

Render tests added under components/emails; bun run lint, bun run check:audits, and type-check pass.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Aug 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview Aug 18, 2026 9:25pm

Request Review

@cursor

cursor Bot commented Aug 18, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
New email template and shared render/subject wiring only; no send pipeline or auth/data-path changes in this PR.

Overview
Adds a sub-processor change notice email for subscribed customers: each listed change (added, replaced, or removed) shows purpose, data categories, location, and a shared effective date formatted in UTC with spelled-out months so notice windows stay unambiguous.

The body covers how to object (mailto and deadline), a link to the public sub-processor list, and an optional subscription preferences link; standard unsubscribe is disabled for this notice type.

Wiring matches other notification templates: exports from the notifications barrel, renderSubprocessorChangeEmail, and a subprocessor-change subject (Upcoming change to {brand} sub-processors). Render tests assert multi-change notices and conditional subscription copy.

Reviewed by Cursor Bugbot for commit 72606dc. Configure here.

@greptile-apps

greptile-apps Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds a customer-facing sub-processor change notification and integrates it with the shared email rendering and subject infrastructure.

  • Presents change type, purpose, data categories, processing location, effective date, and objection deadline.
  • Provides clickable objection, sub-processor-list, and optional subscription-preference actions.
  • Adds render coverage for notice details, multiple changes, links, and optional preference copy.

Confidence Score: 5/5

The PR appears safe to merge.

The previously reported recipient-action issue is fixed at the current head, and no blocking failure remains.

Important Files Changed

Filename Overview
apps/sim/components/emails/notifications/subprocessor-change-email.tsx Adds the notification template and fully addresses the prior recipient-action issue with explicit email and preference links.
apps/sim/components/emails/render-notifications.test.ts Adds render-level coverage for notice content, multiple sub-processors, actionable links, and optional subscription settings.
apps/sim/components/emails/render.ts Exposes the new notification through the shared rendering layer.
apps/sim/components/emails/subjects.ts Registers the notification type and its branded subject line.
apps/sim/components/emails/notifications/index.ts Exports the new template and its public change types.

Reviews (2): Last reviewed commit: "improvement(emails): link the objection ..." | Re-trigger Greptile

Comment thread apps/sim/components/emails/notifications/subprocessor-change-email.tsx Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 72606dc. Configure here.

If you object to this change, reply to this email or write to{' '}
<Link href={`mailto:${objectionEmail}`} style={baseStyles.link}>
{objectionEmail}
</Link>{' '}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Objection mailto opens blank tab

Medium Severity

The objection address is rendered with react-email's Link, which defaults to target="_blank". For a mailto: href that opens a blank tab next to the compose window in most webmail clients. The shared footer already documents this and uses a raw <a> for support mailto links instead.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 72606dc. Configure here.

@waleedlatif1
waleedlatif1 merged commit 56a270e into staging Aug 18, 2026
30 checks passed
@waleedlatif1
waleedlatif1 deleted the feat/subprocessor-change-email branch August 18, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant