fix(forks): name the workspace a sync overwrites instead of "target" - #6822
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview
The sync confirm modal title becomes Reviewed by Cursor Bugbot for commit 70bdcc4. Configure here. |
Greptile SummaryThe PR threads the current workspace name into fork-sync state so pull confirmations and related guidance identify the workspace being overwritten.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/ee/workspace-forking/components/forks.tsx | Passes the current workspace name into fork sync and uses the resolved target name throughout the overwrite confirmation. |
| apps/sim/ee/workspace-forking/components/fork-sync/use-fork-sync.ts | Resolves the written workspace name by sync direction, retaining a safe pull fallback while workspace data loads. |
| apps/sim/ee/workspace-forking/components/fork-sync/fork-sync-view.tsx | Replaces ambiguous target wording in mapping and blocker guidance with the controller’s resolved workspace name. |
| apps/sim/ee/workspace-forking/components/fork-sync/cleared-refs-list.ts | Requires the target workspace name when constructing source-deleted blocker resolutions. |
| apps/sim/ee/workspace-forking/components/fork-sync/cleared-refs-list.test.ts | Updates blocker-resolution tests and verifies that source-deleted guidance names the destination workspace. |
Reviews (2): Last reviewed commit: "fix(forks): name the target workspace in..." | Re-trigger Greptile
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 70bdcc4. Configure here.
Summary
targetWorkspaceNamewasdirection === 'push' ? otherWorkspaceName : 'this workspace'— a hardcoded literal on pull, because the current workspace's name was never plumbed into the sync surface.ForkSyncDetailViewintouseForkSyncso the confirm names the workspace it overwrites: the parent on push, this workspace on pull.<this workspace><parent><this workspace>since the last sync.<parent>since the last sync.targetWorkspaceNametoo: the archived-workflows list and dead-webhook-URL list inside the same confirm, and the "Trigger URLs in …" section heading.Type of Change
Testing
Tested manually.
tsc --noEmitclean,bun run lintclean, all 29 audits pass (check:audits), block-registry check passes, and 604 fork tests pass across 39 files.Checklist