improvement(logs-block): filter runs by trigger type by waleedlatif1 · Pull Request #6824 · simstudioai/sim

waleedlatif1 · 2026-08-18T21:39:25Z

Summary

Adds a trigger-type filter to the Logs block, so a query can be scoped to how the run started (API, Chat, manual, schedule, webhook providers, etc.)
Basic mode is a multi-select of the same options the Logs page offers — core trigger types plus every registered webhook provider — and advanced mode is a comma-separated field for anything not in the list. Both sit behind the canonical triggers param, matching the block's existing workflow filter
Options that share a label are merged into a single entry whose id is the comma-joined set of values, so the reader never sees two identical rows
Backwards compatible: the filter is new and defaults to empty, which omits the param entirely — existing Logs blocks query exactly as they did before

No backend work was needed. The logs_query_runs tool, the /api/logs contract, and the indexed trigger column already accepted a comma-separated triggers list; only the block was missing the control.

Type of Change

Improvement (enhancement to existing functionality)

Testing

Tested manually. Added unit tests covering the param mapping (empty filter omits triggers, multi-select joins, merged ids flatten, advanced string trims, run-details never sends it) and the option merge — verified they fail when the change is reverted. bun run check:audits (29 audits), bun run lint, bun run type-check, and the block-registry subblock-ID stability check all pass.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

The Logs block could filter runs by workflow, status, time, cost, and duration, but not by how the run started — even though the underlying tool, the /api/logs contract, and the indexed trigger column all already accepted a comma-separated triggers filter. Adds a basic multi-select and an advanced free-text field behind the canonical `triggers` param, mirroring the block's existing workflow filter. Options come from the same registry the Logs page reads, so both surfaces name a run's origin identically; values sharing a label are merged into one option. Leaving the filter empty omits the param, so existing blocks query exactly as before.

vercel · 2026-08-18T21:39:32Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Aug 18, 2026 10:37pm

cursor · 2026-08-18T21:39:39Z

PR Summary

Low Risk
Block UI and param normalization only; empty default preserves prior queries, and joinIds regressions are explicitly tested for workflow and status filters.

Overview
Adds a trigger-type filter to the Logs V2 block’s Query Logs operation, aligned with the Logs page: basic multi-select (triggerSelector) and advanced comma input (manualTriggers) both map to the canonical triggers param sent to logs_query_runs. Empty selections omit triggers so existing blocks behave unchanged; Get Run Details still only sends runId.

joinIds now splits each entry on commas and trims every token (so merged option ids like copilot,mothership and hand-typed values work with downstream filters). Tests assert workflowIds and level stay unchanged for typical stored values.

fetchTriggerTypeOptions loads the same trigger vocabulary via a lazy import of getTriggerOptions, merges options that share a label into one dropdown row (comma-joined id), and is covered by unit and live-registry tests.

^{Reviewed by Cursor Bugbot for commit 70e6841. Configure here.}

greptile-apps · 2026-08-18T21:42:20Z

Greptile Summary

The PR adds trigger-type filtering to the Logs block while preserving unfiltered behavior for existing configurations.

Adds basic and advanced trigger controls mapped to the canonical triggers parameter.
Normalizes selected or manually entered trigger values into the API’s comma-separated string format.
Lazily loads and merges trigger options that share a display label.
Adds focused unit and live-registry coverage for parameter mapping and option generation.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
apps/sim/blocks/blocks/logs.ts	Adds trigger filtering and correctly declares the transformed canonical input as a string, resolving the prior coercion issue.
apps/sim/blocks/blocks/logs.test.ts	Covers trigger normalization, operation scoping, backward compatibility, and the corrected input declaration without explicit `any`.
apps/sim/lib/workflows/subblocks/options.ts	Adds lazy trigger-option loading and deterministic merging of entries with identical labels.
apps/sim/lib/workflows/subblocks/options.test.ts	Verifies merged option identifiers and preservation of registry ordering.
apps/sim/lib/workflows/subblocks/trigger-options-live.test.ts	Confirms the lazy import resolves against the real registries and produces populated, uniquely labeled options.

_{Reviews (5): Last reviewed commit: "test(logs-block): exercise the trigger o..." | Re-trigger Greptile}

The generic handler JSON.parses any post-transform input declared 'array' or 'json'. Since `joinIds` has already turned the selection into a comma-separated string by then, the array declaration logged a parse warning on every run, and JSON-looking advanced input would have been turned into an array the tool does not accept. Matches the legacy Logs block, which already declares triggers as a string, and locks the invariant with a test. Also drops `any` from the new test helper.

waleedlatif1 · 2026-08-18T21:45:56Z

@greptile

waleedlatif1 · 2026-08-18T21:45:57Z

@cursor review

joinIds trimmed only the ends of an advanced-mode string, so a hand-typed 'api, schedule, slack' reached the query as ' schedule' and ' slack'. The filters split on commas without trimming, so those tokens matched no stored trigger and the filter silently returned nothing. Splits and trims every entry instead, which also covers empty tokens from a trailing comma and the multi-value ids behind merged trigger labels.

waleedlatif1 · 2026-08-18T21:50:32Z

@greptile

waleedlatif1 · 2026-08-18T21:50:33Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit fd50a97. Configure here.}

joinIds is shared with the workflow and status filters, so the per-entry trimming added for hand-typed triggers must not move their output. Covers every value a stored multi-select or advanced field can hold, plus the block-saved-before-the-filter case where triggers must not reach the query.

waleedlatif1 · 2026-08-18T22:04:21Z

@greptile

waleedlatif1 · 2026-08-18T22:04:22Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit e1b61f5. Configure here.}

The fetcher reaches the block and trigger registries through a lazy import to avoid an initialization cycle, so a mocked test cannot show that the import resolves or that the registry is populated when the dropdown asks. Covers the populated list, unique labels, and the merged Sim agent option.

waleedlatif1 · 2026-08-18T22:37:25Z

@greptile

waleedlatif1 · 2026-08-18T22:37:26Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 70e6841. Configure here.}

greptile-apps Bot reviewed Aug 18, 2026

View reviewed changes

Comment thread apps/sim/blocks/blocks/logs.ts

Comment thread apps/sim/blocks/blocks/logs.test.ts Outdated

cursor Bot reviewed Aug 18, 2026

View reviewed changes

Comment thread apps/sim/blocks/blocks/logs.ts

vercel Bot temporarily deployed to Preview August 18, 2026 21:45 Inactive

vercel Bot temporarily deployed to Preview August 18, 2026 21:50 Inactive

cursor Bot reviewed Aug 18, 2026

View reviewed changes

vercel Bot temporarily deployed to Preview August 18, 2026 22:04 Inactive

cursor Bot reviewed Aug 18, 2026

View reviewed changes

vercel Bot temporarily deployed to Preview August 18, 2026 22:37 Inactive

cursor Bot reviewed Aug 18, 2026

View reviewed changes

waleedlatif1 merged commit 0c09f1d into staging Aug 18, 2026
24 checks passed

waleedlatif1 deleted the feat/logs-block-trigger-filter branch August 18, 2026 22:42

waleedlatif1 mentioned this pull request Aug 19, 2026

v0.8.5: cookie banner, cli updates, knowledgebase connectors improvements #6843

Merged

Uh oh!

Conversation

waleedlatif1 commented Aug 18, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

greptile-apps Bot commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Aug 18, 2026

Uh oh!

waleedlatif1 commented Aug 18, 2026

Uh oh!

waleedlatif1 commented Aug 18, 2026

Uh oh!

waleedlatif1 commented Aug 18, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Aug 18, 2026

Uh oh!

waleedlatif1 commented Aug 18, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Aug 18, 2026

Uh oh!

waleedlatif1 commented Aug 18, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Aug 18, 2026 •

edited

Loading

cursor Bot commented Aug 18, 2026 •

edited

Loading

greptile-apps Bot commented Aug 18, 2026 •

edited

Loading