Skip to content

fix(emcn): prevent leading glyph clipping in chip inputs - #6833

Merged
j15z merged 1 commit into
stagingfrom
fix/chip-input-glyph-clipping
Aug 19, 2026
Merged

fix(emcn): prevent leading glyph clipping in chip inputs#6833
j15z merged 1 commit into
stagingfrom
fix/chip-input-glyph-clipping

Conversation

@j15z

@j15z j15z commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add paint clearance for leading glyphs in shared chip inputs without changing alignment
  • Add regression coverage for the input spacing classes

Type of Change

  • Bug fix

Testing

  • Tested manually
  • 75 EMCN tests passed
  • EMCN and Sim type-checks passed
  • Lint and all 29 audits passed

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Aug 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview Aug 19, 2026 12:12am

Request Review

@cursor

cursor Bot commented Aug 19, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Localized EMCN chip-input layout and styling only; no auth, data, or API changes.

Overview
Fixes leading glyph clipping in ChipInput by adding matching -ml-1 and indent-1 on the inner <input>, giving paint clearance while keeping icon and text alignment the same. Component docs are updated to describe that behavior.

Adds a Vitest/jsdom regression test that asserts those spacing classes are present on the rendered input.

Reviewed by Cursor Bugbot for commit a43693a. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps

greptile-apps Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR prevents leading glyph clipping in the shared chip input by adding equal negative-margin and text-indent utilities, preserving the existing visual alignment.

  • Adds -ml-1 and indent-1 to the inner input.
  • Documents the paint-clearance technique.
  • Adds a focused regression test for both spacing classes.

Confidence Score: 5/5

The PR appears safe to merge with no actionable correctness, security, or repository-rule issues identified.

The balanced negative margin and text indentation provide the intended glyph clearance while preserving alignment, and the new regression test protects that class-level contract.

Important Files Changed

Filename Overview
packages/emcn/src/components/chip-input/chip-input.tsx Adds balanced margin and indentation utilities to create leading paint clearance without changing text alignment.
packages/emcn/src/components/chip-input/chip-input.test.tsx Adds jsdom coverage confirming that the shared input retains both required spacing classes.

Reviews (1): Last reviewed commit: "fix(emcn): prevent leading glyph clippin..." | Re-trigger Greptile

@j15z
j15z merged commit b6ca0d7 into staging Aug 19, 2026
30 checks passed
@j15z
j15z deleted the fix/chip-input-glyph-clipping branch August 19, 2026 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant