improvement(settings): drop the Delete account row's description - #6845
Conversation
The confirmation modal already states the consequence, and states it better: it names the account, enumerates the workspaces that will be deleted, notes which billing transfers instead, marks 'This cannot be undone' in the error color, and requires typing the email to proceed. Nothing is lost by removing the line from the row. The wrapper it shared with the row goes too, now that the row is the section's only child.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview The explanatory copy about permanent deletion and affected data is no longer shown on the settings page; users still see that context in Reviewed by Cursor Bugbot for commit 3719410. Configure here. |
Greptile SummaryRemoves the static description beneath the Delete account setting while preserving the existing guarded confirmation flow.
Confidence Score: 5/5The PR appears safe to merge because the deletion consequences and confirmation safeguards remain in the mandatory modal. The change only removes redundant static copy and a wrapper; the Delete control still opens the guarded confirmation modal before any destructive request can occur.
|
| Filename | Overview |
|---|---|
| apps/sim/app/workspace/[workspaceId]/settings/components/general/general.tsx | Removes redundant destructive-action copy and its layout wrapper without altering the modal trigger or deletion behavior. |
Reviews (1): Last reviewed commit: "improvement(settings): drop the Delete a..." | Re-trigger Greptile
Summary
Removes the description under the Delete account row in General settings, matching #6844 which did the same for the Privacy row.
I checked that the warning isn't lost: the confirmation modal already carries it, and carries it better than the row did. It names the account being deleted, enumerates the workspaces that go with it, notes which ones transfer billing to another admin instead, marks This cannot be undone in the error color, and requires typing the account email before the destructive action is enabled.
So the consequence is stated at the point of action rather than one click early, which is where it does the work.
Also drops the
flex flex-col gap-3wrapper the paragraph shared with the row — with the paragraph gone, the row is the section's only child.Type of Change
Testing
type-check,lint:check, all 29check:audits, and 199 tests pass. No behavior change — only the row's static copy is removed; the modal, its guards, and the delete flow are untouched.Checklist