Skip to content

improvement(settings): drop the Delete account row's description - #6845

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/delete-account-row-description
Aug 19, 2026
Merged

improvement(settings): drop the Delete account row's description#6845
waleedlatif1 merged 1 commit into
stagingfrom
fix/delete-account-row-description

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

Removes the description under the Delete account row in General settings, matching #6844 which did the same for the Privacy row.

I checked that the warning isn't lost: the confirmation modal already carries it, and carries it better than the row did. It names the account being deleted, enumerates the workspaces that go with it, notes which ones transfer billing to another admin instead, marks This cannot be undone in the error color, and requires typing the account email before the destructive action is enabled.

So the consequence is stated at the point of action rather than one click early, which is where it does the work.

Also drops the flex flex-col gap-3 wrapper the paragraph shared with the row — with the paragraph gone, the row is the section's only child.

Type of Change

  • Other: copy/layout cleanup

Testing

type-check, lint:check, all 29 check:audits, and 199 tests pass. No behavior change — only the row's static copy is removed; the modal, its guards, and the delete flow are untouched.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

The confirmation modal already states the consequence, and states it better:
it names the account, enumerates the workspaces that will be deleted, notes
which billing transfers instead, marks 'This cannot be undone' in the error
color, and requires typing the email to proceed. Nothing is lost by removing
the line from the row.

The wrapper it shared with the row goes too, now that the row is the section's
only child.
@vercel

vercel Bot commented Aug 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 19, 2026 5:13am

Request Review

@cursor

cursor Bot commented Aug 19, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Copy and layout-only change in settings; delete flow and modal guards are unchanged.

Overview
Removes the static description under Delete account in General settings so the Account section matches the simpler Privacy row layout (label + action only).

The explanatory copy about permanent deletion and affected data is no longer shown on the settings page; users still see that context in DeleteAccountModal, including the error-styled This cannot be undone line, workspace details, and email confirmation before delete runs.

Reviewed by Cursor Bugbot for commit 3719410. Configure here.

@greptile-apps

greptile-apps Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Removes the static description beneath the Delete account setting while preserving the existing guarded confirmation flow.

  • Simplifies the Account settings section to a single Delete account row.
  • Removes the now-unnecessary column layout wrapper.

Confidence Score: 5/5

The PR appears safe to merge because the deletion consequences and confirmation safeguards remain in the mandatory modal.

The change only removes redundant static copy and a wrapper; the Delete control still opens the guarded confirmation modal before any destructive request can occur.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/settings/components/general/general.tsx Removes redundant destructive-action copy and its layout wrapper without altering the modal trigger or deletion behavior.

Reviews (1): Last reviewed commit: "improvement(settings): drop the Delete a..." | Re-trigger Greptile

@waleedlatif1
waleedlatif1 merged commit 1b30611 into staging Aug 19, 2026
24 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/delete-account-row-description branch August 19, 2026 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant