Skip to content

fix(auth): drop the redundant "Continue with" from the Google sign-in button - #6862

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/google-auth-cta-label
Aug 19, 2026
Merged

fix(auth): drop the redundant "Continue with" from the Google sign-in button#6862
waleedlatif1 merged 1 commit into
stagingfrom
fix/google-auth-cta-label

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #6786, which changed the Google button label to "Continue with Google" and bumped its icon to 20px on both auth surfaces. Two surfaces, two different problems:

Login / signup (social-login-buttons.tsx) — these buttons sit under an AuthDivider label="Or continue with", so the button rendered as "Or continue with → Continue with Google". Its siblings in the same stack are bare "GitHub" and "Microsoft". Restored to "Google", and handed the icon back to the chip's leftIcon slot so it uses the canonical 16px chipContentIconClass like its siblings, instead of a leftAdornment + className size override.

Landing auth modal (auth-modal.tsx) — different surface, no divider, and every button there reads "Continue with X" (Microsoft, GitHub, email). The Google label is correct and stays. Only the icon changes, 20px back to the 18px both siblings use.

Both files are now byte-identical to their pre-#6786 blobs. The Google artwork refresh and the Google Vault product-icon fix from that PR are untouched.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Other

Testing

Checklist

  • Code follows project style guidelines
  • Self-reviewed the changes
  • No new warnings introduced

… button

The login and signup social buttons sit under an "Or continue with" divider,
so "Continue with Google" read as "Or continue with Continue with Google" —
and its siblings on the same stack are bare "GitHub" and "Microsoft". Restore
"Google" and hand the icon back to the chip's own leftIcon slot so it picks up
the canonical 16px chipContentIconClass instead of a className size override.

The landing auth modal is a different surface: every button there reads
"Continue with X" (Microsoft, GitHub, email), so its Google label is correct
and stays. Only its icon changes, 20px back to the 18px both siblings use.
@vercel

vercel Bot commented Aug 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 19, 2026 9:02pm

Request Review

@cursor

cursor Bot commented Aug 19, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Copy and icon presentation only on auth UI; no changes to sign-in flows or credentials handling.

Overview
Reverts the Google OAuth button tweaks from #6786 on the two auth surfaces that regressed.

On login/signup (social-login-buttons.tsx), the Google chip label goes back to Google so it matches GitHub and Microsoft under the existing Or continue with divider (avoiding redundant “Continue with Google”). The icon is wired through leftIcon again instead of a leftAdornment with a 20px override, so it uses the same chip icon sizing as the other providers.

On the landing auth modal (auth-modal.tsx), Continue with Google stays; only the Google icon size is reduced from 20px to 18px to match Microsoft and GitHub in that modal.

Reviewed by Cursor Bugbot for commit 9a55d04. Configure here.

@waleedlatif1
waleedlatif1 merged commit 7c8d290 into staging Aug 19, 2026
23 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/google-auth-cta-label branch August 19, 2026 21:02
@greptile-apps

greptile-apps Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR removes redundant wording from the Google button on the login and signup surfaces and restores canonical icon-slot sizing. It also aligns the landing auth modal’s Google icon with its Microsoft and GitHub siblings.

  • Changes the divider-backed Google button label from “Continue with Google” to “Google.”
  • Uses the Chip component’s standard leftIcon slot for the Google icon.
  • Reduces the landing modal’s Google icon from 20px to 18px.

Confidence Score: 5/5

The PR appears safe to merge with no actionable regressions identified.

The label remains contextualized by the auth divider, the Chip icon prop is compatible with GoogleIcon, and the modal icon sizing now matches both sibling social buttons.

Important Files Changed

Filename Overview
apps/sim/app/(auth)/components/social-login-buttons.tsx The Google button now matches its divider context and sibling provider buttons while using the Chip component’s canonical icon API.
apps/sim/app/(landing)/components/auth-modal/auth-modal.tsx The Google icon now uses the same 18px size and positioning as the modal’s Microsoft and GitHub icons.

Reviews (1): Last reviewed commit: "fix(auth): drop the redundant "Continue ..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant