fix(auth): drop the redundant "Continue with" from the Google sign-in button - #6862
Conversation
… button The login and signup social buttons sit under an "Or continue with" divider, so "Continue with Google" read as "Or continue with Continue with Google" — and its siblings on the same stack are bare "GitHub" and "Microsoft". Restore "Google" and hand the icon back to the chip's own leftIcon slot so it picks up the canonical 16px chipContentIconClass instead of a className size override. The landing auth modal is a different surface: every button there reads "Continue with X" (Microsoft, GitHub, email), so its Google label is correct and stays. Only its icon changes, 20px back to the 18px both siblings use.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview On login/signup ( On the landing auth modal ( Reviewed by Cursor Bugbot for commit 9a55d04. Configure here. |
Greptile SummaryThis PR removes redundant wording from the Google button on the login and signup surfaces and restores canonical icon-slot sizing. It also aligns the landing auth modal’s Google icon with its Microsoft and GitHub siblings.
Confidence Score: 5/5The PR appears safe to merge with no actionable regressions identified. The label remains contextualized by the auth divider, the Chip icon prop is compatible with GoogleIcon, and the modal icon sizing now matches both sibling social buttons.
|
| Filename | Overview |
|---|---|
| apps/sim/app/(auth)/components/social-login-buttons.tsx | The Google button now matches its divider context and sibling provider buttons while using the Chip component’s canonical icon API. |
| apps/sim/app/(landing)/components/auth-modal/auth-modal.tsx | The Google icon now uses the same 18px size and positioning as the modal’s Microsoft and GitHub icons. |
Reviews (1): Last reviewed commit: "fix(auth): drop the redundant "Continue ..." | Re-trigger Greptile
Summary
Follow-up to #6786, which changed the Google button label to "Continue with Google" and bumped its icon to 20px on both auth surfaces. Two surfaces, two different problems:
Login / signup (
social-login-buttons.tsx) — these buttons sit under anAuthDivider label="Or continue with", so the button rendered as "Or continue with → Continue with Google". Its siblings in the same stack are bare "GitHub" and "Microsoft". Restored to "Google", and handed the icon back to the chip'sleftIconslot so it uses the canonical 16pxchipContentIconClasslike its siblings, instead of aleftAdornment+classNamesize override.Landing auth modal (
auth-modal.tsx) — different surface, no divider, and every button there reads "Continue with X" (Microsoft, GitHub, email). The Google label is correct and stays. Only the icon changes, 20px back to the 18px both siblings use.Both files are now byte-identical to their pre-#6786 blobs. The Google artwork refresh and the Google Vault product-icon fix from that PR are untouched.
Type of Change
Testing
bun run type-checkbun run lint:checkChecklist