chore(knowledge): tighten the comments on the quota classification - #6870
chore(knowledge): tighten the comments on the quota classification#6870waleedlatif1 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview In The quota regression test comment in Reviewed by Cursor Bugbot for commit 906757c. Configure here. |
Greptile SummaryThis PR shortens quota-classification documentation without changing executable behavior.
Confidence Score: 5/5The PR appears safe to merge because it changes comments only and introduces no actionable defect. The executable embedding client and its tests are unchanged; the edited comments preserve the existing retry and failover descriptions.
|
| Filename | Overview |
|---|---|
| apps/sim/lib/embeddings/client.ts | Shortens documentation around quota exhaustion and retry eligibility without modifying runtime logic. |
| apps/sim/lib/embeddings/client.test.ts | Condenses an existing regression-test comment without changing setup or assertions. |
Reviews (1): Last reviewed commit: "refactor(knowledge): tighten the comment..." | Re-trigger Greptile
|
Folding this into #6869 rather than spending a PR on a comment trim. |
Follow-up to #6868, which merged before the comments could be shortened.
The TSDoc there explained the incident that motivated the change rather than the code, which is the kind of thing that stops being true and starts misleading. Trimmed to the reason a reader needs:
isQuotaExhaustionBody— keeps "OpenAI returns 429 for both, but only a rate limit reopens"; drops the retelling of the sweep behaviour.isWorthRetrying— keeps the distinction that actually shapes the code, retry against the same provider versus failing over to a different one.quotaExhausted— one line.No behaviour change; comments only. 86 embedding tests pass.