Skip to content

fix(docs): hide unreleased table expiration - #7401

Merged
j15z merged 1 commit into
stagingfrom
fix/remove-ttl-docs
Sep 2, 2026
Merged

fix(docs): hide unreleased table expiration#7401
j15z merged 1 commit into
stagingfrom
fix/remove-ttl-docs

Conversation

@j15z

@j15z j15z commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Remove the unreleased Expiration column from the Tables guide
  • Omit ttl from generated Tables OpenAPI enums while preserving runtime support behind the feature flag

Type of Change

  • Bug fix

Testing

  • bun run lint
  • bun run apps/sim/scripts/check-block-registry.ts origin/staging
  • bun run check:audits
  • bun run docs-manifest:check

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 2, 2026 6:16pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR hides the feature-flagged table-expiration column from public documentation while retaining runtime support.

  • Removes Expiration from the Tables guide.
  • Adds OpenAPI-only enum-value omission metadata to the shared table column-type schema.
  • Extends the OpenAPI generator and tests to omit ttl from generated schemas without changing runtime validation.
  • Regenerates the Tables OpenAPI document.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

Runtime validation continues to accept ttl, while the generated OpenAPI document and user-facing guide consistently hide the feature as intended and tests cover both behaviors.

Important Files Changed

Filename Overview
apps/sim/lib/api/contracts/tables.ts Adds metadata that hides ttl during OpenAPI generation while leaving the runtime Zod enum unchanged.
scripts/openapi/generator.ts Adds validated filtering of selected enum values during JSON Schema generation.
scripts/openapi/generator.test.ts Verifies that enum values are omitted from documentation but remain accepted at runtime.
scripts/openapi/documents.test.ts Verifies that generated Tables documentation contains no exposed ttl enum value.
apps/docs/content/docs/tables/index.mdx Removes unreleased expiration-column documentation.
apps/docs/openapi-v2-tables.json Regenerates table API schemas without the unreleased ttl enum value.

Reviews (1): Last reviewed commit: "fix(docs): hide unreleased table expirat..." | Re-trigger Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@j15z
j15z merged commit 4a19865 into staging Sep 2, 2026
29 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/remove-ttl-docs branch September 2, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant