Skip to content

fix(ship): regenerate docs manifest before validation - #7450

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/review-7446-ui-followups
Sep 3, 2026
Merged

fix(ship): regenerate docs manifest before validation#7450
waleedlatif1 merged 1 commit into
stagingfrom
codex/review-7446-ui-followups

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

Type of Change

  • Bug fix

Testing

  • Exercised the actual Phase A command block with temporary docs-page addition, rename, and removal; verified stale checks fail before regeneration and pass afterward.
  • Injected a docs-manifest generator failure and verified Phase A exits nonzero.
  • Verified generation is idempotent and all temporary docs/generated changes are removed.
  • Independent cleanup/minimality review; React/UI passes are not applicable to this Markdown-only change.
  • bun run lint, bun run lint:check, block-registry validation, bun run check:audits, and bun run docs-manifest:check passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (manual regression checks; no committed test changes)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 3, 2026 8:58pm UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1
waleedlatif1 enabled auto-merge (squash) September 3, 2026 20:58
@waleedlatif1
waleedlatif1 merged commit 67e3f6d into staging Sep 3, 2026
5 of 6 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/review-7446-ui-followups branch September 3, 2026 20:58
@greptile-apps

greptile-apps Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates the shipping workflow to regenerate the committed documentation manifest before validating it.

  • Adds docs-manifest:generate to Phase A’s parallel generator loop.
  • Documents the three generators’ disjoint outputs.
  • Retains explicit generator-failure handling and the Phase B manifest validation gate.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The new generator targets the same artifact checked later in the workflow, propagates failures through the existing status collection, and does not overlap the other Phase A generators’ outputs.

Important Files Changed

Filename Overview
.agents/skills/ship/SKILL.md Adds documentation-manifest regeneration before validation with consistent failure propagation and disjoint parallel outputs.

Reviews (1): Last reviewed commit: "fix(ship): regenerate docs manifest befo..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant