fix(chat): preserve literal code around source chips by waleedlatif1 · Pull Request #7456 · simstudioai/sim

waleedlatif1 · 2026-09-03T21:18:25Z

Summary

Preserve multi-backtick code spans and backtick/tilde-fenced examples containing source or workspace-resource chips.
Keep unmatched delimiter runs as prose, pair only within paragraphs, and recognize longer closing fences.
Bound malformed JSON scanning by rejecting escapes outside JSON strings.
Rebased onto fix(chat): preserve queued edits and render quoted source chips #7452; retains its citation and queued-edit fixes without duplicating them.

Type of Change

Bug fix

Testing

252 message-content tests passed, including delimiter, JSON-marker, and malformed-input scaling regressions.
Reproduced the three-backtick rendering bug and malformed escaped-JSON slowdown on current staging.
Workspace type-checks, lint, all 45 repository audits, generated-artifact checks, and cleanup/simplification review passed.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-09-03T21:18:33Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Sep 3, 2026 9:56pm UTC

waleedlatif1 · 2026-09-03T21:19:30Z

@greptile

waleedlatif1 · 2026-09-03T21:19:31Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-03T21:19:36Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

greptile-apps · 2026-09-03T21:23:15Z

Greptile Summary

This PR updates chat-content sanitization to preserve literal source and workspace-resource tags inside multi-backtick spans and fenced blocks while continuing to unwrap ordinary inline citations.

Groups consecutive backticks and pairs multi-backtick spans within paragraph boundaries.
Recognizes backtick and tilde fences, including unclosed streaming fences and longer valid closers.
Tightens chip JSON matching to bound malformed-input scans.
Adds delimiter, fence, quoted-tag, paragraph-boundary, and scaling regressions.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
apps/sim/app/workspace/[workspaceId]/home/components/message-content/components/chat-content/chat-sanitize.ts	Reworks chip-aware inline-code and fenced-block handling and bounds malformed JSON matching; the previously reported cases are addressed without an eligible residual defect.
apps/sim/app/workspace/[workspaceId]/home/components/message-content/components/chat-content/chat-content.test.ts	Adds comprehensive regressions for delimiter runs, paragraph boundaries, fences, quoted tag text, malformed input, and scaling.
apps/sim/app/workspace/[workspaceId]/home/components/message-content/components/scaling-test-helpers.ts	Generalizes the scaling helper with a configurable input builder while preserving its existing default behavior.

_{Reviews (4): Last reviewed commit: "fix(chat): preserve tilde-fenced citatio..." | Re-trigger Greptile}

cubic-dev-ai

All reported issues were addressed across 3 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

waleedlatif1 · 2026-09-03T21:37:34Z

@greptile

waleedlatif1 · 2026-09-03T21:37:35Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-03T21:37:43Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 3 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

waleedlatif1 · 2026-09-03T21:47:19Z

@greptile

waleedlatif1 · 2026-09-03T21:47:20Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-03T21:47:27Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

waleedlatif1 · 2026-09-03T21:48:01Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-03T21:48:07Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 3 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

waleedlatif1 · 2026-09-03T21:56:27Z

@greptile

waleedlatif1 · 2026-09-03T21:56:28Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-03T21:56:35Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 3 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

greptile-apps Bot reviewed Sep 3, 2026

View reviewed changes

Comment thread ...space/[workspaceId]/home/components/message-content/components/chat-content/chat-sanitize.ts Outdated

Comment thread ...space/[workspaceId]/home/components/message-content/components/chat-content/chat-sanitize.ts Outdated

cubic-dev-ai Bot reviewed Sep 3, 2026

View reviewed changes

Comment thread ...space/[workspaceId]/home/components/message-content/components/chat-content/chat-sanitize.ts Outdated

fix(chat): preserve literal code around source chips

2d5b329

waleedlatif1 force-pushed the codex/fix-release-review-findings branch from c327392 to 2d5b329 Compare September 3, 2026 21:36

vercel Bot temporarily deployed to Preview September 3, 2026 21:36 Inactive

waleedlatif1 changed the title ~~fix(chat): preserve backticks inside citation JSON~~ fix(chat): preserve literal code around source chips Sep 3, 2026

cubic-dev-ai Bot reviewed Sep 3, 2026

View reviewed changes

greptile-apps Bot reviewed Sep 3, 2026

View reviewed changes

Comment thread ...space/[workspaceId]/home/components/message-content/components/chat-content/chat-sanitize.ts

fix(chat): scope delimiter pairing to paragraphs

6ba39c3

vercel Bot temporarily deployed to Preview September 3, 2026 21:47 Inactive

cubic-dev-ai Bot reviewed Sep 3, 2026

View reviewed changes

Comment thread ...space/[workspaceId]/home/components/message-content/components/chat-content/chat-sanitize.ts Outdated

fix(chat): preserve tilde-fenced citations

f5c88ba

vercel Bot temporarily deployed to Preview September 3, 2026 21:56 Inactive

cubic-dev-ai Bot reviewed Sep 3, 2026

View reviewed changes

Uh oh!

Conversation

waleedlatif1 commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

waleedlatif1 commented Sep 3, 2026

Uh oh!

waleedlatif1 commented Sep 3, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 3, 2026

Uh oh!

greptile-apps Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Sep 3, 2026

Uh oh!

waleedlatif1 commented Sep 3, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 3, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Sep 3, 2026

Uh oh!

waleedlatif1 commented Sep 3, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 3, 2026

Uh oh!

waleedlatif1 commented Sep 3, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 3, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Sep 3, 2026

Uh oh!

waleedlatif1 commented Sep 3, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 3, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

waleedlatif1 commented Sep 3, 2026 •

edited

Loading

vercel Bot commented Sep 3, 2026 •

edited

Loading

greptile-apps Bot commented Sep 3, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading