Skip to content

fix(extension): keep site access compatible with strict CSP - #9524

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/extension-dialog-csp
Oct 31, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/extension-dialog-csp

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Keep Site access compatible with the extension's strict CSP by hosting the shared Sim modal surface in a native dialog.
  • Preserve native focus isolation and Escape, Close, and backdrop dismissal without an injected scroll-lock stylesheet.
  • Prepare extension 0.1.1 and make the packaged-browser checks distinguish capture requests from unrelated tab metadata queries.

Type of Change

  • Bug fix

Testing

The packaged-browser CSP regression failed on the old modal and passes with the fix. Negative controls also caught removal of gesture protection and backdrop dismissal. Final staging and release-source E2E runs passed concurrently. Verified the actual Chrome side panel against the hosted app. Root tests, all 29 workspace type checks, 62 audits, lint, generators, and block-registry validation passed. Cleanup and test-audit completed; permissions and CSP are unchanged.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@waleedlatif1
waleedlatif1 requested a review from a team as a code owner October 31, 2026 09:31
@vercel

vercel Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 31, 2026 9:36am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Replaces the Site access modal host with a native dialog while keeping the shared Sim surface.

  • Site access opens in a native dialog that keeps its modal behavior under strict CSP.
  • Capture checks count tab queries from each action and check activation in both browser contexts.
  • The extension package and generated browser manifest identify the release as version 0.1.1.

No actionable issues were found. Browser checks were reviewed but not run.

Reviews (1) · Last reviewed commit: "fix(extension): keep site access compati..." · Reviewed by Greptile

This branch was successfully deployed

1 active deployment
Preview — 8dd54849 Deployed Oct 31, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant