Skip to content

fix(knowledge): let members connect their own account to a member-access connector - #9602

Merged
waleedlatif1 merged 2 commits into
stagingfrom
fix/kb-connector-member-enroll
Nov 3, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
fix/kb-connector-member-enroll

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • knowledge.connectors.members.enroll (read role) had no web entry point since legacy indexed search was removed; useStartConnectorMemberEnrollment had no caller and viewerMembership was never read
  • Connector cards now show the viewer's own state when it isn't connected, not gated on edit access: "Connect your account" (not enrolled / invited), "Reconnect" (needs reauth), and the server's own message with no action for revoked and unverified-email
  • Connect follows the existing flows: desktop system browser, provider popup for search-index KBs, invitation page in a new tab otherwise; the connector list refreshes on completion or on returning to the tab, and cancels on unmount

Type of Change

  • Bug fix

Testing

  • hooks/queries/kb/connectors.test.ts, connectors-cache.test.tsx (9 passing)
  • bun run lint, check:client-boundary, check:react-query, check:source-conventions, pre-push type-check

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 3, 2026 2:59am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new actionable issues were found.

Summary

Lets members connect their own accounts from connector cards without edit access.

  • Connector cards let members connect or reconnect their own accounts.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Member clicks Connect] --> B{Desktop?}
  B -->|Yes| C[Connect in system browser]
  B -->|No| D{Search index?}
  D -->|Yes| E[Connect in provider popup]
  D -->|No| F[Open invitation tab]
  C --> G[Refresh connector list]
  E --> G
  F --> H[Member returns to original tab]
  H --> G
  G --> I{Account connected?}
  I -->|No, invitation flow| H
  I -->|Yes| J[Remove connection prompt and listener]
Loading

Reviews (2) · Last reviewed commit: "fix(knowledge): keep watching member enr..." · Reviewed by Greptile

Comment thread apps/sim/hooks/queries/kb/connectors.ts Resolved
Comment thread apps/sim/hooks/queries/kb/connectors.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 133c671 into staging Nov 3, 2026
81 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/kb-connector-member-enroll branch November 3, 2026 03:45

This branch was previously deployed

1 inactive deployment
Preview — 5865b444 Deployed Nov 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant