Repository navigation
Retire the JavaScript CLI in cli/; e2e tests the Rust CLI - #57
Merged
Merged
Conversation
@simular-ai/box on npm is the Rust simular-box from simular-ai/box-cli since 1.0.0, and this repo's npm trusted publisher was removed, so cli/ (the 0.2.x JavaScript CLI, its copied protos, tests and publish job) can no longer ship anything. Protos live only in simular-ai/box. The client install matrix and the live staging check move to e2e/ and now run the CLI version the Claude plugin pins (npx -y @simular-ai/box@X.Y.Z, or BOX_CLI), so they test what users run. publish-cli.yml becomes ci.yml without the JS check and publish jobs. Claude-Session: https://claude.ai/code/session_01JpjBLYLub5jiuXCLhoSg2s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #56.
Why
@simular-ai/boxon npm has been the Rustsimular-boxfrom simular-ai/box-cli since 1.0.0 (1.1.1 islatest), and this repo's npm trusted publisher was removed.cli/(the 0.2.x JavaScript CLI) can't ship anything, and publishing from here would be wrong. Its copied protos (cli/proto, used only bycli/src/box/connection.js) go too: protos now live only in simular-ai/box.What changes
cli/in full: source, bin,proto/, unit tests, fake box, smoke test, eslint config and lockfile. Also removed: the JScheckjob (lint, unit, smoke, pack) and the npmpublishjob with itscli-v*tag trigger.e2e/: the client install matrix (install-matrix.mjs,clients.json,isolated-env.mjs) and the live staging check (live.mjs,mcp-tools.mjs). They used to run the JS CLI. They now run the version the Claude plugin pins,npx -y @simular-ai/box@X.Y.Zread fromclaude/skills/box-offload/SKILL.md(e2e/cli.mjs), or$BOX_CLIto test a local box-cli build. The assertions are unchanged. JSON fromdoctoris parsed from stdout only, and npm's update notice is off in the isolated env.publish-cli.ymlis renamed toci.ymland keeps theplugins,clientsandlivejobs. Its paths now point ate2e/. Pushes to main also run whenclaude/or.claude-plugin/change, because the pin decides what the e2e tests.README.mdandclaude/README.mdnow point at@simular-ai/box/ simular-ai/box-cli instead ofcli/.Testing
node e2e/install-matrix.mjswith CLI 1.1.0 for codex, opencode, gemini-cli and openclaw at the pinned versions, and for claude-code with a local 2.1.322. All passed.claude plugin validateon.and./claude, the pin check,npm pack ./dsh --dry-run, and the OpenClaw build, install, inspect and doctor. All passed.BOX_CI_KEY). This PR's CI covers them.Left for later (manual, not in this PR)
The
npmGitHub environment and thecli release tagstag ruleset are now unused.🤖 Generated with Claude Code
https://claude.ai/code/session_01JpjBLYLub5jiuXCLhoSg2s