Fix artifact upload retries - #1003
Merged
Merged
Conversation
Cover direct and tuple-form multipart POST files, along with file-like PUT request bodies
Rewind multipart POST files and file-like PUT bodies before Tenacity retries the request Fixes #1002
kzscisoft
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix artifact upload retries
Issue: #1002
Python Version(s) Tested: Python 3.11.13
Operating System(s): Linux Ubuntu 26.04
📝 Summary
Artifact upload retries reused already-consumed file streams, causing subsequent attempts to send empty or truncated data and potentially trigger S3
BadDigesterrors.The retry handling now rewinds file-like request bodies before retrying multipart
POSTand file-likePUTrequests.🔍 Diagnosis
Tenacity retried the request with the same stream object, which remained positioned at EOF after the first attempt. This affected both multipart and presigned artifact upload paths.
🔄 Changes
PUTbodies before retries.✔️ Checklist
Unit and integration tests passing.Relevant tests pass; the full suite has unrelated nightly-server compatibility failures.