Skip to content

Bug fix - when attributes or filters was None, the string null was sent to the server #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alahiff wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Bug fix - when attributes or filters was None, the string null was sent to the server #1007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ef9656
Bug fix - need to return None if attributes/filters is None, not 'null'
andrewl-uk Sep 4, 2026
cd00261
Update fake data to match stricter requirements imposed by the server
andrewl-uk Sep 4, 2026
ecfb9a5
Forgot to correct this instance of dummy_bucket
andrewl-uk Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions simvue/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,8 +279,8 @@ def get_runs(
_runs = Run.get(
count=count_limit,
offset=start_index,
attributes=json.dumps(attributes),
filters=json.dumps(filters),
attributes=json.dumps(attributes) if attributes is not None else None,
filters=json.dumps(filters) if filters is not None else None,
return_basic=True,
return_system=system_info,
return_timing=timing_info,
Expand Down
20 changes: 10 additions & 10 deletions tests/unit/test_s3_storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ def test_create_s3_online() -> None:
disable_check=True,
is_tenant_useable=False,
is_default=False,
region_name="fictionsville",
region_name="eu-fiction-1",
access_key_id="dummy_key",
secret_access_key="not_a_key",
ca_cert="invalid_ca_cert",
bucket="dummy_bucket",
bucket="dummy-bucket",
is_enabled=False
)
_storage.commit()
Expand All @@ -34,8 +34,8 @@ def test_create_s3_online() -> None:
assert _storage.to_dict()
assert _storage.name == _uuid
assert _storage.config.endpoint_url == "https://not-a-real-url.io/"
assert _storage.config.region_name == "fictionsville"
assert _storage.config.bucket == "dummy_bucket"
assert _storage.config.region_name == "eu-fiction-1"
assert _storage.config.bucket == "dummy-bucket"
assert _storage.created
assert dict(Storage.get())
_storage.delete()
Expand All @@ -51,10 +51,10 @@ def test_create_s3_offline(offline_cache_setup) -> None:
name=_uuid,
endpoint_url="https://not-a-real-url.io",
disable_check=True,
region_name="fictionsville",
region_name="eu-fiction-1",
access_key_id="dummy_key",
secret_access_key="not_a_key",
bucket="dummy_bucket",
bucket="dummy-bucket",
is_default=False,
is_tenant_useable=False,
is_enabled=False,
Expand All @@ -65,8 +65,8 @@ def test_create_s3_offline(offline_cache_setup) -> None:
_local_data = json.load(in_f)
assert _local_data.get("name") == _uuid
assert _local_data.get("config").get("endpoint_url") == "https://not-a-real-url.io/"
assert _local_data.get("config").get("region_name") == "fictionsville"
assert _local_data.get("config").get("bucket") == "dummy_bucket"
assert _local_data.get("config").get("region_name") == "eu-fiction-1"
assert _local_data.get("config").get("bucket") == "dummy-bucket"
assert _local_data.get("is_enabled") == False
assert not _local_data.get("status", None)
assert not _local_data.get("user", None)
Expand All @@ -82,8 +82,8 @@ def test_create_s3_offline(offline_cache_setup) -> None:
assert _online_storage.name == _uuid
assert _online_storage.is_enabled == False
assert _online_storage.config.endpoint_url == "https://not-a-real-url.io/"
assert _online_storage.config.region_name == "fictionsville"
assert _online_storage.config.bucket == "dummy_bucket"
assert _online_storage.config.region_name == "eu-fiction-1"
assert _online_storage.config.bucket == "dummy-bucket"

_online_storage.read_only(False)
_online_storage.delete()
Expand Down
Loading