Skip to content

Build the image on Node 26 LTS and nginx 1.31 - #207

Open
YektaY wants to merge 1 commit into
mainfrom
yektay/docker-node-26
Open

YektaY wants to merge 1 commit into
mainfrom
yektay/docker-node-26

Conversation

@YektaY

@YektaY YektaY commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

Description

  • The build stage moves from node:24-alpine to node:26-alpine, the active LTS.
  • Corepack 0.36.0 is installed from npm before corepack enable, so pnpm still comes from packageManager (pnpm 11.1.1).
  • The runtime stage moves from nginx:1.29-alpine to nginx:1.31-alpine, as in ci: bump the docker-images group in /docker with 2 updates #194.

Motivation

Dependabot's #194 bumps the build stage to node:25-alpine, and its validate-build check fails at RUN corepack enable with corepack: not found. Node 25 and later no longer bundle corepack. Fixing that on Node 25 isn't enough:

  • Node 25 is an odd-numbered release and reached end of life on 2026-06-01. Its image hasn't been rebuilt since April.
  • Corepack 0.36.0 declares ^22.22.2 || ^24.15.0 || >=26.0.0, which leaves Node 25 out.

Node 26 also lacks a bundled corepack, which is why the install step is needed. Once this merges, main is at or past both of #194's versions, so Dependabot should close it as superseded. If it doesn't, close it by hand.

Screenshots

None. Image-only change.

Pre-merge checklist

  • Code works interactively in the browser (not opened in a browser). I built the image locally and ran it with a placeholder API key: /trace/ and its JS bundle return 200 from nginx 1.31.8, running as UID 101.
  • New/changed components are covered in the test suite where possible (no app code changed)
  • Test suite passes locally (pnpm test): unchanged by this PR
  • Linting passes (pnpm lint): unchanged by this PR
  • Test suite passes on GitHub Actions

Dependabot's #194 moves the build stage to node:25-alpine, and the
image build fails there: Node 25 no longer bundles corepack, so
`corepack enable` is not found. Node 25 is also past end of life
(2026-06-01), and the current corepack (0.36.0) doesn't support it.

Use node:26-alpine, the active LTS, and install corepack 0.36.0 from
npm before enabling it, so pnpm still comes from packageManager. Take
#194's nginx 1.31 bump as well.
@YektaY
YektaY requested a review from a team as a code owner November 18, 2026 00:19

@ngAlexander9 ngAlexander9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants