Repository navigation
Vault latency feature flag and proto changes - #2452
Open
russell-stern wants to merge 9 commits into
Open
russell-stern wants to merge 9 commits into
russell-stern wants to merge 9 commits into
Conversation
Contributor
✅ API Diff Results -
|
russell-stern
force-pushed
the
vault_latency
branch
from
October 8, 2026 13:18
d01384f to
f1c026e
Compare
jmank88
reviewed
Oct 20, 2026
| type invalidRecipientKeyError struct{ msg string } | ||
|
|
||
| func (e invalidRecipientKeyError) Error() string { return e.msg } | ||
| func (e invalidRecipientKeyError) Is(target error) bool { return target == ErrInvalidRecipientKey } |
Contributor
There was a problem hiding this comment.
Shouldn't this match itself too?
jmank88
reviewed
Oct 20, 2026
| // retried under a new request ID. | ||
| var ErrSecretVersionSkew = errors.New(SecretVersionSkewMessage) | ||
|
|
||
| func IsSecretVersionSkew(err error) bool { |
Contributor
There was a problem hiding this comment.
Could we support errors.Is for ErrSecretVersionSkew instead?
jmank88
reviewed
Oct 20, 2026
Comment on lines
+99
to
+105
| type Decrypter interface { | ||
| Decrypt(encrypted []byte) ([]byte, error) | ||
| } | ||
|
|
||
| type DecryptFunc func(encrypted []byte) ([]byte, error) | ||
|
|
||
| func (f DecryptFunc) Decrypt(encrypted []byte) ([]byte, error) { return f(encrypted) } |
Contributor
There was a problem hiding this comment.
Could these be unexported?
Suggested change
| type Decrypter interface { | |
| Decrypt(encrypted []byte) ([]byte, error) | |
| } | |
| type DecryptFunc func(encrypted []byte) ([]byte, error) | |
| func (f DecryptFunc) Decrypt(encrypted []byte) ([]byte, error) { return f(encrypted) } | |
| type decrypter interface { | |
| Decrypt(encrypted []byte) ([]byte, error) | |
| } | |
| type decryptFunc func(encrypted []byte) ([]byte, error) | |
| func (f decryptFunc) Decrypt(encrypted []byte) ([]byte, error) { return f(encrypted) } |
Contributor
There was a problem hiding this comment.
oh I think the func adapter could be moved to the test file too
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.