Repository navigation
x/config/cli fields take priority over map entries on env vars - #2486
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes implement the intended precedence with regression coverage and no identified blocking issues.
No open issues 🎉
What changed in this PR
Updates x/config/cli so environment variables assigned to fields take precedence over matching map entries.
Changes:
- Tracks field-owned environment variables and skips them during map-entry decoding.
- Preserves collision checks between maps.
- Documents precedence and adds regression coverage.
| File | Description |
|---|---|
| x/config/cli/README.md | Documents field precedence over map entries. |
| x/config/cli/entries.go | Skips field-owned variables when decoding map entries. |
| x/config/cli/entries_test.go | Tests field precedence and retained map collision checks. |
| x/config/cli/binder.go | Records field-owned variables and adjusts collision validation. |
Review effort: Balanced
Contributor
📊 API Diff Results
|
cedric-cordenier
approved these changes
Oct 21, 2026
jmank88
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Real use case is along the lines of the fields Headers and HeadersTTL