Skip to content

Adding suppression for false positive compiler warning #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewdavidsmith merged 1 commit into from
Oct 21, 2026
+9 −6
Merged

Adding suppression for false positive compiler warning #337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/utils/xcounts.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,16 +92,19 @@ make_error_code(xcounts_err e) {
template <typename T>
static inline std::uint32_t
fill_output_buffer(const std::uint32_t offset, const MSite &s, T &buf) {
#pragma GCC diagnostic push
#pragma GCC diagnostic error "-Wstringop-overflow=0"
// NOLINTBEGIN(*-pointer-arithmetic)
auto buf_end = buf.data() + buf.size();
auto res = std::to_chars(buf.data(), buf_end, s.pos - offset);
auto buf_end = std::data(buf) + std::size(buf);
auto res = std::to_chars(std::data(buf), buf_end, s.pos - offset);
*res.ptr++ = '\t';
res = std::to_chars(res.ptr, buf_end, s.n_meth());
*res.ptr++ = '\t';
res = std::to_chars(res.ptr, buf_end, s.n_unmeth());
*res.ptr++ = '\n';
return std::distance(buf.data(), res.ptr);
return std::distance(std::data(buf), res.ptr);
// NOLINTEND(*-pointer-arithmetic)
#pragma GCC diagnostic push
}

int
Expand Down Expand Up @@ -161,7 +164,7 @@ main_xcounts(int argc, char *argv[]) { // NOLINT(*-avoid-c-arrays)
std::cerr << opt_parse.option_missing_message() << '\n';
return EXIT_SUCCESS;
}
if (leftover_args.size() != 1) {
if (std::size(leftover_args) != 1) {
std::cerr << opt_parse.help_message() << '\n';
return EXIT_SUCCESS;
}
Expand Down Expand Up @@ -267,12 +270,12 @@ main_xcounts(int argc, char *argv[]) { // NOLINT(*-avoid-c-arrays)

site.chrom += '\n';
const std::int64_t sz = size(site.chrom);
if (bgzf_write(out.f, site.chrom.data(), sz) != sz)
if (bgzf_write(out.f, std::data(site.chrom), sz) != sz)
ec = xcounts_err::failed_to_write_file;
}
if (keep_all_sites || site.n_reads > 0) {
const std::int64_t sz = fill_output_buffer(offset, site, buf);
if (bgzf_write(out.f, buf.data(), sz) != sz)
if (bgzf_write(out.f, std::data(buf), sz) != sz)
ec = xcounts_err::failed_to_write_file;
offset = site.pos;
}
Expand Down
Loading