fix(sio): parse Engine.v3 namespace query without Object.fromEntries - #5537
Open
FirmaSpring wants to merge 1 commit into
Open
fix(sio): parse Engine.v3 namespace query without Object.fromEntries#5537FirmaSpring wants to merge 1 commit into
FirmaSpring wants to merge 1 commit into
Conversation
Keep protocol-3 connect auth parsing compatible with engines.node >=10.2.0. Co-authored-by: FirmamentalSpring <287222957+FirmaSpring@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behavior
socket.iostill advertisesengines.node: >=10.2.0. Engine.v3 namespace handshake parsing inClient._parseNamespaceusesObject.fromEntries()onURLSearchParams, which does not exist on Node 10/11.A protocol-3 connect packet with query auth therefore throws on the Node versions the package still claims to support.
New behavior
Parse the query with a local
objectFromEntrieshelper that does not depend onObject.fromEntries.Other information (e.g. related issues)
Related leftover from #5527. Separate from the engine.io HTTP/uWS query parsers.