Repository navigation
[Topology.Grid,Mapping.Linear] BarycentricMapperRegularGridTopology: grid resolution read once per loop - #6427
Merged
Conversation
fredroy
added
pr: enhancement
fredroy
force-pushed
the
grid_data_access
branch
from
October 21, 2026 23:33
e7aa838 to
5ac8cca
Compare
…grid resolution read once per loop GridTopology::getHexaCopy(i) read the Data d_n 9 times (once, then once per node through point()/getIndex), and BarycentricMapperRegularGridTopology calls it for each mapped point in apply, applyJ, applyJT, getJ and draw
fredroy
force-pushed
the
grid_data_access
branch
from
October 26, 2026 21:59
5ac8cca to
f3411ec
Compare
bakpaul
approved these changes
Oct 27, 2026
hugtalbot
approved these changes
Oct 29, 2026
hugtalbot
added
pr: status ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create static functions in GridTopology and using them in BarycentricMapperRegularGridTopology to avoid calling d_n.getValue() a substantial number of times.
and adding a benchmark scene (focusing on the grid+mapping)
master:
10000 iterations done in 11.9005 s ( 840.298 FPS)PR:
10000 iterations done in 5.6872 s ( 1758.33 FPS)The gain scales with the number of points in the output state
[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if