Skip to content

[Framework] Fix remaining warnings - #6438

Open
fredroy wants to merge 9 commits into
sofa-framework:masterfrom
fredroy:fix_remaining_warnings_framework
Open

[Framework] Fix remaining warnings#6438
fredroy wants to merge 9 commits into
sofa-framework:masterfrom
fredroy:fix_remaining_warnings_framework

Conversation

@fredroy

@fredroy fredroy commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Based on

tested on the 3 systems and in debug

[with-all-tests]

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

fredroy and others added 8 commits October 28, 2026 10:44
@fredroy
[All] Fix remaining deprecation warnings
e716a26 
- Replace BaseObject/Constraint.inl includes with BaseComponent/LagrangianConstraint.inl
- Remove unused MechanicalGetNonDiagonalMassesCountVisitor includes
- Silence header warnings for deprecated visitors still used internally
- Use DifferentialOperations::pushforwardCoord in StaticEquilibriumIntegrationScheme
- Use computeTriangleBarycentricCoordinates instead of deprecated barycoefs functions
- Avoid deprecated Vec conversion in DrawToolGL::drawFrame
@fredroy
Restore StaticEquilibriumIntegrationScheme as it is done in an other …
77ad5de 
…branch
@fredroy
Merge branch 'master' into fix_deprecation_warnings
91cb51f
@fredroy
Merge branch 'master' into fix_deprecation_warnings
476e9fa
@fredroy
fix merge
b7949ad
@fredroy
[Framework] Fix remaining compilation warnings
44b8115 
- BaseMass: make the deprecated getPotentialEnergy(mparams) overload
  non-virtual (it was final) so Mass<T> no longer hides it
- ImplicitIntegrationScheme: mark integration factor methods override
- Remove unused MechanicalGetNonDiagonalMassesCountVisitor includes
- MechanicalOperations: silence deprecated-header messages for the
  PropagateDx visitors it still uses internally
@fredroy
[Framework] Fix variable shadowing warnings
71c3cd8 
- BaseLink::readFromSnapshot: rename the link value string so the
  loop variable linkPath no longer hides it (C4456)
- ObjectElement::initNode: rename local parent to parentElement so it
  no longer hides the Element::parent member (C4458)
@fredroy
[Framework] Fix unreachable code warnings in Debug
71ff7b5 
- CompressedRowSparseMatrixGeneric::compressCSR: wrap the body in
  if constexpr (Policy::CompressZeros) instead of an early return
- FixedArrayTypeInfo::setSize: move the fallback return into an
  else branch of the if constexpr
- BackTrace: remove the dead return after the switch in SigDescription,
  the default case already returns
@fredroy fredroy added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code pr: based on previous PR PR based on a previous PR, therefore to be merged ONLY subsequently pr: AI-aided Label notifying the reviewers that part or all of the PR has been generated with the help of an AI labels Oct 30, 2026
@fredroy fredroy mentioned this pull request Oct 30, 2026
Open
@fredroy
[Helper] Fix clang-cl warnings
e19253d 
- DynamicLibrary: explicitly cast the GetProcAddress result to void*
  (-Wmicrosoft-cast)
- PipeProcess: remove the set-but-unused busy flag in the Windows
  branch (-Wunused-but-set-variable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr: AI-aided Label notifying the reviewers that part or all of the PR has been generated with the help of an AI pr: based on previous PR PR based on a previous PR, therefore to be merged ONLY subsequently pr: clean Cleaning the code pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fredroy