[CI] Await the example button before tapping it in Argent flows - #4482
[CI] Await the example button before tapping it in Argent flows#4482j-piasecki wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughFive Argent test flows now wait for their searched example to become visible before tapping it. ChangesExample search flow synchronization
Merge Risk: ⚪ Minimal · up to The updated CI flows wait for searched examples to render before opening them, reducing timing-related test failures. No current merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
## Description The search results may not be rendered yet when the flow taps the example button right after typing into the search field. Await the button in every flow before tapping it. ## Test plan Run the flows in `.argent/flows` and check that they pass.
6743923 to
97a8e7c
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The change is low-risk and directly addresses a known timing race in the E2E flows by adding appropriate visibility awaits before taps.
Pull request overview
This PR improves the stability of the Argent E2E flows by ensuring the searched example entry is visible before attempting to tap it, preventing races where the list hasn’t re-rendered after typing into the search field.
Changes:
- Added an
await: { visible: { text: "<Example Name>" } }step after typing into the search input in each affected flow. - Ensured the await targets match the example names used by the app (e.g.,
Nested touchables,Basic LongPress).
File summaries
| File | Description |
|---|---|
.argent/flows/timer-test.yaml |
Waits for “Timer” to appear after searching before tapping it. |
.argent/flows/shared-value-test.yaml |
Waits for “Shared Value” to appear after searching before tapping it. |
.argent/flows/nested-touchables-test.yaml |
Waits for “Nested touchables” to appear after searching before tapping it. |
.argent/flows/basic-tap-test.yaml |
Waits for “Basic Tap” to appear after searching before tapping it. |
.argent/flows/basic-long-press-test.yaml |
Waits for “Basic LongPress” to appear after searching before tapping it. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Description
The search results may not be rendered yet when the flow taps the example button right after typing into the search field. Await the button in every flow before tapping it.
Test plan
Run the flows in
.argent/flowsand check that they pass.