Skip to content

[Web] Restore enabled on a full config replace #4487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
j-piasecki wants to merge 1 commit into from
+12 −1
Open

[Web] Restore enabled on a full config replace #4487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native-gesture-handler/src/web/handlers/GestureHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -789,7 +789,7 @@ export default abstract class GestureHandler implements IGestureHandler {

public setGestureConfig(config: Config) {
this.resetConfig();
this.updateGestureConfig(config);
this.updateGestureConfig({ ...config, enabled: config.enabled ?? true });
}

public updateGestureConfig(config: Partial<Config>): void {
Expand Down
11 changes: 11 additions & 0 deletions packages/react-native-gesture-handler/src/web/handlers/__tests__/GestureHandler.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import type { Config } from '../../interfaces';
import EventManager from '../../tools/EventManager';
import type { GestureHandlerDelegate } from '../../tools/GestureHandlerDelegate';
import GestureHandler from '../GestureHandler';
Expand Down Expand Up @@ -25,6 +26,16 @@ function createHandler(enabled: boolean) {
return handler;
}

describe('GestureHandler web config reset', () => {
test('a config without enabled restores the enabled default', () => {
const handler = createHandler(false);

handler.setGestureConfig({} as Config);

expect(handler.enabled).toBe(true);
});
});

describe('GestureHandler web event manager attachment', () => {
test('registers listeners for an initially enabled handler', () => {
const manager = new TestEventManager({});
Expand Down
Loading