[Web] Refresh the DOM after a full config replace - #4488
Conversation
## Description resetConfig clears touchAction, userSelect and enableContextMenu, but the DOM was only refreshed when the new config carried one of those keys. resetConfig now marks the DOM as stale and updateGestureConfig flushes it. The web delegate ignores updateDOM before init. ## Test plan Added tests in `GestureHandler.test.ts`.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughChangesWeb DOM synchronization
Suggested reviewers: Merge Risk: ⚪ Minimal · up to Web gesture configuration resets now refresh DOM settings after reconfiguration, while early DOM update requests are safely deferred until initialization. No outstanding merge-readiness risk is evident. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
resetConfig clears touchAction, userSelect and enableContextMenu, but the DOM was only refreshed when the new config carried one of those keys. resetConfig now marks the DOM as stale and updateGestureConfig flushes it. The web delegate ignores updateDOM before init.
Test plan
Added tests in
GestureHandler.test.ts.