Skip to content

Surface underlying transaction errors in the CLI #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lorisleiva merged 1 commit into from
Sep 4, 2026
Merged

Surface underlying transaction errors in the CLI #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions clients/js/pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
allowBuilds:
esbuild: false
Comment thread
lorisleiva marked this conversation as resolved.
11 changes: 4 additions & 7 deletions clients/js/src/cli/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
address,
ClientWithRpc,
ClientWithTransactionPlanning,
ClientWithTransactionSending,
Commitment,
compileTransaction,
createClient,
Expand All @@ -32,7 +33,6 @@ import {
SolanaRpcSubscriptionsApi,
TransactionMessage,
TransactionPlan,
TransactionPlanExecutor,
TransactionSigner,
} from '@solana/kit';
import { solanaRpc, TransactionPlannerConfig } from '@solana/kit-plugin-rpc';
Expand Down Expand Up @@ -131,10 +131,7 @@ function cliConfigs(configs: SolanaConfigs) {
*/
function cliRunOrExport(options: ExportOption & ExportEncodingOption) {
return <
T extends ClientWithRpc<GetLatestBlockhashApi> &
ClientWithTransactionPlanning & {
transactionPlanExecutor: TransactionPlanExecutor;
},
T extends ClientWithRpc<GetLatestBlockhashApi> & ClientWithTransactionPlanning & ClientWithTransactionSending,
>(
client: T,
) =>
Expand All @@ -144,8 +141,8 @@ function cliRunOrExport(options: ExportOption & ExportEncodingOption) {
if (options.export) {
await exportTransactionPlan(transactionPlan, client, options);
} else {
// TODO: progress + error handling.
await client.transactionPlanExecutor(transactionPlan);
// TODO: progress reporting.
await client.sendTransactions(transactionPlan);
Comment thread
lorisleiva marked this conversation as resolved.
logSuccess('Operation executed successfully');
}
},
Expand Down
Loading