Repository navigation
docs: fix getRequestEvent import in v1 request events - #1692
Open
reynoldsalec wants to merge 1 commit into
Open
reynoldsalec wants to merge 1 commit into
reynoldsalec wants to merge 1 commit into
Conversation
|
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description(required)
The SolidStart v1 Request events page says
getRequestEventcomes from@solidjs/web. That is the Solid 2.0 package, which is only published as 2.0 prereleases. In Solid 1.x it is exported fromsolid-js/web, which is what the v1 middleware page and thegetRequestEventreference page use.This changes
@solidjs/webtosolid-js/webon that one line.Found this running a readability benchmark for our Docs For Agents site, LMK if you want me to put up a bigger PR with the rest of the stuff I found or if you'd be interested in a free SaturnDocs subscription, can probably hook you up through our open source program.
Related issues & labels