Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening the scratchpad with files in the URL hash (
/#<compressed tabs>) shows the default counter instead of the imported files.The scratchpad resource reads
localStoragewhen the edit page is created, before the effect that handles the hash runs. The effect writes the imported files tolocalStorageand strips the hash, but nothing tells the resource to read again. The editor keeps the default tabs, and the autosave then writes them back over the import.The effect now bumps a
scratchpadVersionsignal after writing the import, and the resource source includes it, so the resource reads the scratchpad again and the editor shows the imported files. #201 handles this the same way in its Solid 2 port. This change fixes it on the current app so hash links and iframe embeds work before that lands. The motivating case is embedding playground examples in the Solid docs (solidjs/solid-docs#1669).Verified with a production build (
pnpm build, thenvite preview) in Chromium, using a hash that holds amain.tsxplus animport_map.jsonpinningsolid-js@2.0.0-rc.18:/after an import keeps the imported code./with no hash and empty storage still shows the default counter.oxfmt --check,oxlintandtsc --noEmitinpackages/playgroundpass.🤖 Generated with Claude Code