fix: set explicit Content-Type on seroval stream server function responses - #2301
Merged
birkskyum merged 3 commits intoAug 19, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 649498b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
lxsmnsyc
approved these changes
Aug 19, 2026
birkskyum
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2295.
JSON-mode seroval-stream server function responses shipped without a
Content-Typeheader, so intermediaries that content-sniff header-less responses (e.g. Gonet/http-based reverse proxies like kamal-proxy) injected their own guess. This made the transport deployment-dependent and, on v1's client dispatch order, caused silent client-side navigation hangs.As discussed in #2295, this sets
Content-Type: text/plain; charset=utf-8— matching the 1.x fix in #2092 — next to the existingX-Start-Typeheader, in both the success and the error serialization paths ofhandleServerFunction. The v2 client dispatches onX-Start-Type, so this changes no client behavior; it only makes the wire format explicit.Changes:
packages/start/src/fns/handler.ts: set the header in both seroval JSON-stream paths (js mode already setstext/javascript)packages/start/src/fns/handler.spec.ts: regression tests for the success and error paths (assertX-Start-Typeandcontent-type)vitest runinpackages/start: 98/98 passing.