Repository navigation
chore(release): use npm trusted publishing for scip-python releases - #235
Merged
Merged
Conversation
The release job has no NPM_TOKEN secret, so npm publish fails with ENEEDAUTH and the Docker image is never pushed. Publish with npm trusted publishing (OIDC) like scip-typescript (#511, #514). Node 24 ships npm 11, which trusted publishing requires. Amp-Thread-ID: https://ampcode.com/threads/T-01a16041-ef1e-774a-957e-9f7122a62a0e Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.6.7 release run (39689663660) failed at
npm publishwithENEEDAUTH:secrets.NPM_TOKENresolves to empty, so the Docker image for INC-541 (#233) was never pushed.This switches the release job to npm trusted publishing (OIDC), the same change scip-typescript made in sourcegraph/scip-typescript#511 and #514, whose v0.5.1 release succeeded today:
id-token: writepermission for the jobregistry-urlandNODE_AUTH_TOKENBefore merging: the npm package
@sourcegraph/scip-pythonmust have a trusted publisher configured for repositorysourcegraph/scip-pythonand workflowscip-release.yml.Docker Hub login still uses
DOCKER_USERNAME/DOCKER_PASSWORD. scip-typescript reads these from org-level secrets and they worked for its v0.5.1 release.