Repository navigation
Build the autoindex image from the release checkout; prepare v0.6.8 - #236
Merged
Merged
Conversation
npm now holds newly published versions for malware scanning (about five minutes), so the v0.6.7 release built its image with 0.6.6 from the registry. Pack the package in the workflow and install that tarball in Dockerfile.autoindex instead. build-push-action defaults to a Git context, which does not contain the untracked tarball, so build from the workspace with context: . Amp-Thread-ID: https://ampcode.com/threads/T-01a16041-ef1e-774a-957e-9f7122a62a0e Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a16041-ef1e-774a-957e-9f7122a62a0e Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.6.7 release published to npm and pushed
sourcegraph/scip-python:v0.6.7(sha256:fab683cc…), but the image contains scip-python 0.6.6. Since July, npm scans newly published versions for malware before they can be installed, usually for about five minutes (changelog).Dockerfile.autoindexrannpm install -g @sourcegraph/scip-pythonabout a minute afternpm publishand got the previous version.Change
Dockerfile.autoindexinstalls the tarball fromnpm packinpackages/pyright-scipinstead of the registry version.@sourcegraph/srcstill comes from npm.scip-release.ymlandscip-docker.ymlrunnpm pack(itsprepackcleans and builds) instead ofnpm run build, and passcontext: .tobuild-push-action. Withoutcontext, the action builds from a fresh Git checkout, which doesn't contain the untracked tarball. That also means the build step the workflows already had never affected the image.Test plan
I reproduced the release job locally: Node 24 from the new base,
npm install,npm pack, thendocker build -f Dockerfile.autoindex ..scip-python --versionandnpm ls -greport 0.6.8. The tarball is removed from the image.tool_info.version, which is now 0.6.8.The
docker-scipcheck on this PR builds the image the new way.After merging, tag
v0.6.8and repin its digest in sourcegraph/sourcegraph.