Skip to content

Menu item action handlers: use non-variadic signatures #413

Open

Description

@6and8

The MenuItemActionHandler_* functions are declared void __cdecl f(int, ...). As far as I can see they are only called through the menu item tables, never with extra arguments, so a fitting non-variadic signature (for example void __cdecl f(int menuItemID)) would be clearer.

Raised by TheRedDaemon in #408; gynt said the variadic part will go away later.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions