Skip to content

Fix processSingleTimeTick after the 3a1c7f771 header sync - #374

Merged
gynt merged 1 commit into
sourcehold:mainfrom
kotijekriv:fix/sync-3a1c7f771-tail
Nov 8, 2026
Merged

gynt merged 1 commit into
sourcehold:mainfrom
kotijekriv:fix/sync-3a1c7f771-tail

Conversation

@kotijekriv

Copy link
Copy Markdown
Contributor

Main (3a1c7f7) has one .cpp file of its own that no longer compiles: the Ghidra sync 3a1c7f7 moved SkirmishStatistics' yearStart .. monthEnd into the new union SkirmishStatisticsTailUnion tail (as tail.tail1), and Game/GameStateStructures/processSingleTimeTick.cpp still stores finalResults.yearEnd and finalResults.monthEnd. This PR names them through tail.tail1, the same offsets, and changes nothing else: no header and no status line.

File Was Main's path now
Game/GameStateStructures/processSingleTimeTick.cpp finalResults.yearEnd, finalResults.monthEnd finalResults.tail.tail1.yearEnd, .monthEnd

Built with the bundled MSVC1400-SP1, natively on Windows, against the Steam Stronghold Crusader.exe (3bb0a8c1…5387ac5a): a compile of every .cpp under src/OpenSHC on main leaves two failures, this one and UI/MenuModalComposition/setSliderParameters2.cpp, whose new signature (the slider types the sync took from #354) comes with #354. processSingleTimeTick read 100.0% in a full build just before the sync (303fe1c), and with this change quick_diff gives the same 202 instructions (ratio 0.9901, the call targets only). status_regression.py finds nothing below a known score.

The same kind of fix as #343, #350, #368 and #372.

Other PRs: the ready #354 (which brings setSliderParameters2.cpp's new signature), and the drafts #313, #318, #321 (whose SkirmishStatistics change this sync took), #327, #328, #356, #360 and #363.

🤖 Generated with Claude Code

The Ghidra sync 3a1c7f7 moved SkirmishStatistics' yearStart .. monthEnd into the union
SkirmishStatisticsTailUnion tail (as tail.tail1). processSingleTimeTick (0x0045CA20) still stored
finalResults.yearEnd and monthEnd; it now names them through tail.tail1, the same offsets. No header or
status line changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@gynt
gynt added this pull request to the merge queue Nov 8, 2026
Merged via the queue into sourcehold:main with commit 7dbaf5b Nov 8, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants