Skip to content

Fix main's build: drawHeaderTextBanner and its 15 callers take eTextSections - #387

Merged
gynt merged 1 commit into
sourcehold:mainfrom
kotijekriv:fix/drawHeaderTextBanner-eTextSections
Nov 10, 2026
Merged

gynt merged 1 commit into
sourcehold:mainfrom
kotijekriv:fix/drawHeaderTextBanner-eTextSections

Conversation

@kotijekriv

Copy link
Copy Markdown
Contributor

Main d5d965d doesn't compile 16 files. The Ghidra sync 6c1e0bd declared PencilRenderCore::drawHeaderTextBanner's textGroupIndex as eTextSections (the header line from #384). Main's definition still takes an int (C2511), and 15 of its callers pass a bare number (C2664).

This PR takes #384's versions of those 16 files, unchanged, so main builds again now. #384 merges cleanly after it; if #384 goes first, this one can be closed.

  • The definition takes eTextSections and drops its cast.
  • Each caller names its text group (TEXT_SCENARIO 7, TEXT_GAME_OPTIONS 5, TEXT_XPLAY_WAITING_ROOM 2, TEXT_MAINOPTIONS 1), with the banner's text from cr.tex above the call. The text numbers are decimal, and each file includes its own header first.

Measured:

🤖 Generated with Claude Code

Ghidra sync 6c1e0bd declares drawHeaderTextBanner's textGroupIndex as
eTextSections (the header line from sourcehold#384). Main's definition still takes an
int, and 15 of its callers pass a bare number, so these 16 files don't
compile on d5d965d (C2511 for the definition, C2664 for each caller).

These are sourcehold#384's versions of the 16 files, unchanged (from 1262303,
db68fc5 and 85b9d29): the definition takes eTextSections, each caller
names its text group with the banner's text above the call, and the own
header is included first. sourcehold#384 then merges cleanly on top of this.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@gynt
gynt added this pull request to the merge queue Nov 10, 2026
Merged via the queue into sourcehold:main with commit 847c77b Nov 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants