Repository navigation
Conversation
MapPropertiesState (15), LandscapeState (7), EntityState (6), Entities (3), Trees (1), Map (1). Style: locals at first assignment, decimal literals, clang-format. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Style guide reading (advisory, posted once) 4 possible deviation(s) from REIMPLEMENTATION_STYLE_GUIDE.md across 4 of the 33 reimplemented The match comes first. Where the ugly form is what matched, it stays -- that is the guide's own overriding rule, and rule 21 asks for a one-line comment saying what was measured so the next reader does not retry it. This report is posted once, when the PR opens, and is not repeated on later pushes.
WhereRule 9 — Prefer
Rule 14 — The shape of a file
Rule 18 — Use the name, not the number
|
| namespace { | ||
|
|
||
| // the part of a scenario event up to the end of its condition list | ||
| struct ScenarioEventConditionsCopy { |
There was a problem hiding this comment.
Secret header change! I will add this to the .hpp files and then we can merge.
There was a problem hiding this comment.
@6and8 its upstream can you refer to that hpp file here? Or does that change the match?
There was a problem hiding this comment.
Done: it now includes OpenSHC/Map/ScenarioEventConditionsCopy.hpp and the local struct is gone. Still 100%. I also made the main includes relative in the whole PR.
… header; main includes relative Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reimplements 33
Mapfunctions, all at 100%:MapPropertiesState(15): activateScenarioTypeEvents, commitBuildingAvailability, determineScenarioMissionTypeAndResetEvents, getDifficultyMultipliedValue, getEventIDForTimeUntilDefeatEventType, isMapperAvailable, loadMapSiegeHeaderSections, pruneInvalidEventTriggerLinks, removeEventAtIndex, removeProcessedInvasionEvents, resetEuroUnitRestrictions, sortEventsByDate, spawnAttackWaveForPlayer, sumUnitCounts, sumUnitPointsLandscapeState(7): findTree, getValueFrom0UpTo3ForTreeTypeAndTreeStage, placeAppleTree, selectClosestAppleTree, setupBabyTreeLocation, updateTrees, updateWindEntityState(6): drawEntityEffect, initializeSeagullMovementVector, setEntityParameters, setProjectileEntityValues2, setProjectileTargetPosition, updateEntityMicroMovementEntities(3): AFireSpreadFunction, UpdateArrowEntity, UpdateCrossbowArrowEntityTrees(1): UpdateTree5Map(1): ResetSomeValuesFunctionUnkNo header changes. The only status lines touched are these 33.
Checked with a build of this branch on top of
main, containing every source file of the touched classes (55 files): all 33 functions measure 100%, and main's own 22 functions in those classes keep their scores. One exception predates this PR:EntityState::activateProjectileEntityis listed at 100% on main but measures 45.5% with or without this PR. The original returnsentityID(mov eax, esibeforeret 4), while main declares itvoid.🤖 Generated with Claude Code