Repository navigation
Conversation
…es 4 arguments The original ends StoreLocalTime with a plain ret and no return value, and the callback with ret 0x10. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Style guide reading (advisory, posted once) 9 possible deviation(s) from REIMPLEMENTATION_STYLE_GUIDE.md across 9 of the 29 reimplemented The match comes first. Where the ugly form is what matched, it stays -- that is the guide's own overriding rule, and rule 21 asks for a one-line comment saying what was measured so the next reader does not retry it. This report is posted once, when the PR opens, and is not repeated on later pushes.
WhereRule 9 — Prefer
Rule 14 — The shape of a file
Rule 22 — Prefer descriptive code
|
gynt
added a commit
that referenced
this pull request
Nov 13, 2026
TheRedDaemon
requested changes
Nov 15, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…AllyGoodsRequest parameter names, DAT_LastTeamMemberIndex is an int Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ntext), ProcessReleaseDogs takes the display colour Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…check, TRUE for the resolution flags, BT_CESSPIT, named parameters, no needless casts Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…cmp symbol and costs RecalculateAllies 5 points); keep its casts Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… RAT = 1) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…goodsRequestAmountByPlayer) Both live in the asked player's data and are indexed by the requesting player: resource type (0 = no request) and amount. Field rename only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ays a while Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
TheRedDaemon
approved these changes
Nov 16, 2026
TheRedDaemon
left a comment
Contributor
There was a problem hiding this comment.
Nothing from my side remains. Once the headers fit, it can be merged.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reimplements 29
SynchronyandGamefunctions, all at 100%:Synchrony::Actions(14): GateOpenOrClose, OpenOrCloseDrawbridge, ProcessAllyAcceptsRequest, ProcessAllyDeniesRequest, ProcessAllyDeniesRequest2, ProcessAllyGoodsRequest, ProcessAllyRequestAttackDefense, ProcessAllyRequestingGoods, ProcessBuildingSleepUpdate, ProcessBuyOrSell, ProcessRecruitUnit, ProcessReleaseDogs, ProcessTowerRepair, TryAcquireAmmunitionOrPlanToBuyStoneSynchrony(8): ClickDestroyBuilding, DirectPlayModemRelated_MemoryAllocationCallback, EnumDisplayModesCallback, MemCopyFromParameter, PutPlayerIntoRandomSlot, ResetAiVariationArrayValue, SetAIPlayerNickNames, SyncPlayerGroupArraysGame::Skirmish(5): RecalculateAllies, SetupSkirmishBalanceAndOrIntensity, SkirmishLobbySetupStructure::commitSkirmishSettings, StoreCurrentGameIntoTemporarySKMasterEntry, StoreLocalTimeGame::ScenarioEvents::InGameEventUnionVersion(2): initializeScenarioEvent, resetEventTwo declaration fixes, in their own commit:
Game::Skirmish::StoreLocalTimereturnsvoid(wasint): the original ends with a plainretand sets no return value. Main's two callers ignore the result.Synchrony::DirectPlayModemRelated_MemoryAllocationCallbacktakes a 4th argument: it is a__stdcallLPDPENUMADDRESSCALLBACKand the original returns withret 0x10. Main's caller passes it through a cast, unchanged.The only status lines touched are these 29.
Checked with a build of this branch on top of
main, containing every source file of the touched folders plus main's three callers of the changed declarations (41 files): all 29 functions match. 28 measure 100%;MemCopyFromParametermeasures 96.7% because reccmp leaves the security cookie and__security_check_cookieunnamed in the original, which is the only difference. Main's own 12 functions keep their scores:createDirectPlayInterfaceModem(96.1%) andMenuView_MissionFinishedTransition_Prepare(99.0%) also differ only in those cookie names and, for the first, the DirectPlayCreate import thunk.🤖 Generated with Claude Code