Repository navigation
Conversation
ResetCredits clears it with fldz/fstp in the original. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Style guide reading (advisory, posted once) 4 possible deviation(s) from REIMPLEMENTATION_STYLE_GUIDE.md across 4 of the 23 reimplemented The match comes first. Where the ugly form is what matched, it stays -- that is the guide's own overriding rule, and rule 21 asks for a one-line comment saying what was measured so the next reader does not retry it. This report is posted once, when the PR opens, and is not repeated on later pushes.
WhereRule 14 — The shape of a file
|
| this->helpTextLinkActive = FALSE; | ||
| this->textSurfaceTarget = Rendering::Enums::RT_SCREEN_MENU; | ||
| this->field_0x1348 = 0; | ||
| int file = MACRO_CALL(OS_Func::_ucrt_open)("cr.tex", _O_BINARY, 0); |
There was a problem hiding this comment.
Please use the string-literals include. for this. Applies to all literals here.
There was a problem hiding this comment.
Done. _ucrt_open takes a char*, so cr.tex uses the macro from string-macros.hpp; the language names use string-literals.hpp.
There was a problem hiding this comment.
Oh, can you adapt the signature of _ucrt_open then? It should have the same signature like _open which it is proxied to in OS.cpp.
This should allow to use the sting-literals file instead of the macro.
If it becomes clear that a param should actually be const (like when taking a literal), you are free to change the signature.
There was a problem hiding this comment.
Done: _ucrt_open takes char const* like _open now (its own commit, OS.hpp / OS.func.hpp / OS.cpp), and cr.tex uses s_cr_tex_005a6334 from string-literals.hpp. All callers of _ucrt_open compile and score the same as before.
# Conflicts: # src/OpenSHC/Globals/FLOAT_00ec083c.hpp
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…and colours in the construction-cost text, string-literals in loadCRTex, loadMenuElements uses the declared member, no needless casts Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
TheRedDaemon
left a comment
There was a problem hiding this comment.
A single comment remaining.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reimplements 23 functions from
UI,Rendering,TextandAudio:UI::Credits(14): AppendCreditsBinkVideoCommand, AppendCreditsBinkVideoWithAudioCommand, AppendCreditsFixedImageCommand, AppendCreditsImageEndCommand, AppendCreditsImageTransitionCommand, AppendCreditsShowImageCommand, AppendCreditsSoundEntry, AppendCreditsTextCommand, AppendCreditsTextEndCommand, EndCreditsSegmentAndAdvanceToNext, InsertElementIntoAnArrayAt_ec0348, InsertElementIntoArrayAt_ec0348_3, RenderScrollingCreditsTextFrame, ResetCreditsUI(4): Menu::loadMenuElements, MenuHandlerState::initializeUI, MenuViews::Credits::MenuView_Credits_DoEveryFrame, BottomLeftTextDisplayState::renderCurrentlyDisplayedTextConstructionCostRendering(2): InitializeColors, Bink::AIMessageQueue::playNextStoredBinkVideoText::TextManager(1): loadCRTexAudio::SFX(2): ComputeCurrentPlayerRanking, ComputePlayerPoints1One header change, in its own commit:
INT_00ec083cis afloat(wasint).ResetCreditsclears it withfldz/fstpin the original; no other source file on main uses it.The only status lines touched are these 23.
Checked with a build of this branch on top of
main, containing every source file of the touched folders (51 files): 18 of the 23 measure 100%. The other five differ only in symbols that reccmp leaves unnamed in the original (it has no relocations): the loop-end compare against the next global inResetCredits(95.0%),EndCreditsSegmentAndAdvanceToNext(98.4%) andInsertElementIntoArrayAt_ec0348_3(97.0%), plus float constants and_ftol2_sseinInsertElementIntoAnArrayAt_ec0348(95.7%) andRenderScrollingCreditsTextFrame(97.0%). The instructions are identical.Main's own 28 functions in those folders keep their scores. Six of them are below 100% in this build for the same unnamed-symbol reason, with or without this PR:
TicksStartCounter,RenderActiveCreditsElements,Constructor_Menu,handleMenuItems,renderConstructionMenu, andUpdateUnitLossSpeechFeedback(84.4%, listed at 84.0%).🤖 Generated with Claude Code