Repository navigation
Reimplement 176 static initializers and GetStringBasedOnHardcodedMaps - #405
Merged
Merged
Conversation
…gBasedOnHardcodedMaps Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Style guide reading (advisory, posted once) 11 possible deviation(s) from REIMPLEMENTATION_STYLE_GUIDE.md across 11 of the 176 reimplemented The match comes first. Where the ugly form is what matched, it stays -- that is the guide's own overriding rule, and rule 21 asks for a one-line comment saying what was measured so the next reader does not retry it. This report is posted once, when the PR opens, and is not repeated on later pushes.
WhereRule 14 — The shape of a file
|
gynt
approved these changes
Nov 13, 2026
kotijekriv
added a commit
to kotijekriv/OpenSHC
that referenced
this pull request
Nov 13, 2026
Brings in sourcehold#397 (merged as 5ec4011), so this PR no longer shows its commits, plus sourcehold#290, sourcehold#402 and sourcehold#405. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reimplements 176 functions, almost all of them static initializers:
Global::Init(174): 148Constructor_*static constructors and 26Create*DisplayElementinitializers. The constructors build their global and register its destructor withatexit; theCreate*ones construct a display element with its position and render callback.Meta(1):Destructor_MenuModal_UnusedWinCondition.Global(1):GetStringBasedOnHardcodedMaps.No header changes. The only status lines touched are these 176. None of these functions is in another open PR: I checked every open PR by path, file name and function address, and left out the 8 constructors that are already in #241, #242, #265, #275, #291, #292, #295, #366 and #392.
Checked with a build of this branch on top of
main, containing every source file inGlobal/Init,MetaandGlobal(471 files), compared function by function with a full build of my working branch: the instructions are identical in all 176. 149 of them measure 70-94% in this build only because they push a callback oratexitdestructor address that reccmp leaves unnamed in the original (it has no relocations); 174 status lines say so (counted: only the pushed callback address is unnamed in the original). The numbers depend on which callbacks are reimplemented in the build: when the callback itself is reimplemented the push resolves to a trampoline to the same address. Main's 295 functions there keep their scores.🤖 Generated with Claude Code