Repository navigation
Adding ParentUserId and Subscribed to MessageEvent - #271
Merged
soxtoby merged 1 commit intoNov 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fields that Slack sends on messages read through
conversations.historyandconversations.replieshave no property onMessageEvent, the type SlackNet reads those messages into. I found them comparing real responses of both methods withMessageEvent. My app doesn't read them through a workaround today. This models them. It is one commit.ParentUserId(parent_user_id), sent on the replies in a thread.Subscribed(subscribed), sent on the parent message of a thread.Compatibility
Additive only. The new properties default to null and false, and the message subtypes that inherit from
MessageEventget them too.Testing
New
MessageThreadTests: a reply withparent_user_id, a thread parent withsubscribed, and a message outside a thread, in the style ofMessageTeamTests(including that the fields no longer land inExtraProperties)../do testpasses (786 tests).Seen in a real response:
subscribedin realconversations.historyandconversations.repliesresponses, andparent_user_idin a realconversations.repliesresponse.Not verified: what they mean. The reference shows them only in the example responses of
conversations.repliesand "Retrieving messages" and never describes them, so the properties have no doc comment. Reading the examples,parent_user_idis the author of the thread's parent message andsubscribedsits on the parent message next toreply_count. I also haven't run my app against a local pack of this branch.