Repository navigation
Adding Team and Enterprise to MemberJoinedChannel, and Team to MemberLeftChannel - #273
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reference for
member_joined_channeldocumentsteamandenterprise, and the one formember_left_channeldocumentsteam, butMemberJoinedChannelandMemberLeftChannelhave no properties for them, so they only show up inExtraProperties. They say which workspace and org a person who joined or left a channel is from. I found them comparing the reference pages of the events my app subscribes to with their SlackNet classes. This models them. It is one commit.MemberJoinedChannel.Team(team): "Team ID, identifying which workspace the user is from." andEnterprise(enterprise): "Enterprise ID, identifying which org the user is from. The value will be blank if the user's team is not an Enterprise organization."MemberLeftChannel.Team(team), with the same description as on the joined event.Compatibility
Additive only, but like #264 it moves fields: code that reads
teamorenterpriseout ofExtraPropertieson these two events stops finding them there.Testing
New
MemberChannelEventTests: the joined event with both fields (the payload from the reference, which also checks that nothing is left inExtraProperties), one without them, and the left event withteam../do testpasses (786 tests).Not verified: I haven't captured either event from a live workspace, so these follow the reference pages and their examples only. My app subscribes to both events and doesn't use these fields today.