fix(acp): await child background work - #31
Merged
Conversation
danielkov
force-pushed
the
fix/acp-structured-subagent-completion
branch
from
August 26, 2026 19:50
40b59d8 to
e624386
Compare
danielkov
enabled auto-merge (squash)
August 26, 2026 19:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes nested Kit ACP turns wait for child-owned background work and synthesize its results before resolving
subagent,prompt, orfork. Applies structured completion to ACP v1 and v2 while preserving depth-0 explicit background behavior.Motivation
A child could emit a provisional final response while a detached descendant was still running, causing the root-visible call to finish and leaving the descendant unsupervised. Fixes #28.
Impact
Nested subagent calls remain active until their background work reaches quiescence. Cancelling or closing the owning session now cooperatively cancels descendants and force-cancels tasks that do not settle within the bounded grace period.
Technical details
Structured completion boundary
Only ACP drivers started below depth 0 use structured completion. At a provisional terminal boundary, the actor waits for owned background work, consumes the published result, and drives a replacement synthesis turn until the child returns a final response with no active work.
Race-free completion handoff
Background jobs track activity generations and terminal publication by tool call ID. The actor cannot resolve between execution finishing and the task manager publishing the corresponding completion event, avoiding invisible or duplicate autonomous continuations.
Validation
cargo fmt --all -- --checkcargo test --quietgit diff --check