Repository navigation
Fix seven never-matching clauses in Registry Keys Used For Persistence - #4429
Open
Varunpoojari wants to merge 1 commit into
Open
Varunpoojari wants to merge 1 commit into
Varunpoojari wants to merge 1 commit into
Conversation
Seven clauses paired a registry key path with registry_key_name set to a value name. For Sysmon EventID 13 the full TargetObject, including the value name, maps to registry_path, so these clauses could not match. Match each on the full value path (IFEO: registry_value_name=Debugger), and fix the lone backslashes in the BootExecute clause. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DsERxbuN8zLtzYkvRM3Vxp
Varunpoojari
requested review from
P4T12ICK,
RavenTait,
ljstella,
nasbench,
onurmerdogan,
patel-bhavin,
pyth0n1c,
rosplk and
tccontre
as code owners
November 16, 2026 20:41
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4426, which left this detection out. Seven clauses pair a registry key path with
registry_key_name="<value>"(Debugger, Security Packages ×2, Load, Svchost, BootExecute, auto_update). For Sysmon EventID 13,data_sources/sysmon_eventid_13.ymlmaps the fullTargetObject, including the value name, toregistry_path, and the value name toregistry_value_name. So a path ending at the key (for example*\CurrentControlSet\Control\Lsa) never matches, andregistry_key_namenever equals a bare value name. None of these seven clauses can fire.Details
Each clause now matches on the full value path, as
windows_registry_bootexecute_modification.ymlalready does. For IFEO the clause usesregistry_value_name=Debugger, as other ESCU detections do. The BootExecute clause also had lone backslashes (\Control\Session Manager), which are doubled here.*...\Image File Execution Options*ANDregistry_key_name=Debuggerregistry_value_name=Debugger*\CurrentControlSet\Control\LsaAND key_nameSecurity Packages*\CurrentControlSet\Control\Lsa\Security Packages*\Control\Lsa\OSConfigAND key_nameSecurity Packages*\Control\Lsa\OSConfig\Security Packages*currentVersion\WindowsAND key_nameLoad*\currentVersion\Windows\Load*\CurrentVersionAND key_nameSvchost*\CurrentVersion\Svchost\**\\CurrentControlSet\Control\Session ManagerAND key_nameBootExecute*\CurrentControlSet\Control\Session Manager\BootExecute*\Software\RunAND key_nameauto_update*\Software\Run\auto_updateBumps
version(35 → 36) andmodification_date. Nothing else in the file changes.Testing
contentctl-ng buildpasses. I have not tested this against live data, since I don't have a Splunk instance with the Sysmon TA to hand, so the change rests on the field mapping indata_sources/sysmon_eventid_13.ymland on how the other detections above match the same values. The existing true-positive test (Run keys in the T1547.001 dataset) is unaffected.Checklist
<platform>_<mitre att&ck technique>_<short description>nomenclature (unchanged)🤖 Generated with Claude Code
https://claude.ai/code/session_01DsERxbuN8zLtzYkvRM3Vxp