Skip to content

Fix seven never-matching clauses in Registry Keys Used For Persistence - #4429

Open
Varunpoojari wants to merge 1 commit into
splunk:developfrom
Varunpoojari:fix/registry-persistence-value-paths
Open

Varunpoojari wants to merge 1 commit into
splunk:developfrom
Varunpoojari:fix/registry-persistence-value-paths

Conversation

@Varunpoojari

Copy link
Copy Markdown

Follow-up to #4426, which left this detection out. Seven clauses pair a registry key path with registry_key_name="<value>" (Debugger, Security Packages ×2, Load, Svchost, BootExecute, auto_update). For Sysmon EventID 13, data_sources/sysmon_eventid_13.yml maps the full TargetObject, including the value name, to registry_path, and the value name to registry_value_name. So a path ending at the key (for example *\CurrentControlSet\Control\Lsa) never matches, and registry_key_name never equals a bare value name. None of these seven clauses can fire.

Details

Each clause now matches on the full value path, as windows_registry_bootexecute_modification.yml already does. For IFEO the clause uses registry_value_name=Debugger, as other ESCU detections do. The BootExecute clause also had lone backslashes (\Control\Session Manager), which are doubled here.

Clause Before After
IFEO Debugger path *...\Image File Execution Options* AND registry_key_name=Debugger same path AND registry_value_name=Debugger
LSA Security Packages path *\CurrentControlSet\Control\Lsa AND key_name Security Packages path *\CurrentControlSet\Control\Lsa\Security Packages
LSA OSConfig Security Packages path *\Control\Lsa\OSConfig AND key_name Security Packages path *\Control\Lsa\OSConfig\Security Packages
Windows Load path *currentVersion\Windows AND key_name Load path *\currentVersion\Windows\Load
Svchost path *\CurrentVersion AND key_name Svchost path *\CurrentVersion\Svchost\*
BootExecute path *\\CurrentControlSet\Control\Session Manager AND key_name BootExecute path *\CurrentControlSet\Control\Session Manager\BootExecute
auto_update path *\Software\Run AND key_name auto_update path *\Software\Run\auto_update

Bumps version (35 → 36) and modification_date. Nothing else in the file changes.

Testing

contentctl-ng build passes. I have not tested this against live data, since I don't have a Splunk instance with the Sysmon TA to hand, so the change rests on the field mapping in data_sources/sysmon_eventid_13.yml and on how the other detections above match the same values. The existing true-positive test (Run keys in the T1547.001 dataset) is unaffected.

Checklist

  • Validate name matches <platform>_<mitre att&ck technique>_<short description> nomenclature (unchanged)
  • CI/CD jobs passed ✔️
  • Validated SPL logic (against the field mapping only, not live data)
  • Validated tags, description, and how to implement (unchanged)
  • Verified references match analytic (unchanged)
  • Confirm updates to lookups are handled properly (no lookups changed)

🤖 Generated with Claude Code

https://claude.ai/code/session_01DsERxbuN8zLtzYkvRM3Vxp

Seven clauses paired a registry key path with registry_key_name set to a
value name. For Sysmon EventID 13 the full TargetObject, including the
value name, maps to registry_path, so these clauses could not match.
Match each on the full value path (IFEO: registry_value_name=Debugger),
and fix the lone backslashes in the BootExecute clause.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DsERxbuN8zLtzYkvRM3Vxp

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant