Skip to content

Fix the source of the windows-xml.log sample in Elevated Group Discovery with PowerView - #4430

Merged
nasbench merged 2 commits into
splunk:developfrom
TT5H:fix-powerview-test-source
Nov 19, 2026
Merged

nasbench merged 2 commits into
splunk:developfrom
TT5H:fix-powerview-test-source

Conversation

@TT5H

@TT5H TT5H commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Fixes #4418.

Details

In the tests block of detections/endpoint/elevated_group_discovery_with_powerview.yml, the second sample windows-xml.log is declared with the source XmlWinEventLog:Microsoft-Windows-Sysmon/Operational. The file holds 8 events, all Security event 5145 on the Security channel, and the descriptor AD_discovery.yml in attack_data declares it as XmlWinEventLog:Security.

This changes the source of that sample to XmlWinEventLog:Security and sets modification_date. version stays at 11, because only the tests block changes. The atomic GUID mapping update (#4315) also set only modification_date for edits outside the search.

I ingested the second sample in Splunk Enterprise 9.3.14 (Splunk_SA_CIM 6.4.0, Splunk_TA_windows 9.1.2, Splunk_TA_microsoft_sysmon 5.0.0), once with each source:

Source of the sample Event types Tags
XmlWinEventLog:Microsoft-Windows-Sysmon/Operational (current) endpoint_services_processes, windows_event_signature, windows_ta_data track_event_signatures
XmlWinEventLog:Security (this change) the same three, plus wineventlog_security, wineventlog_windows, winsec os, security, success, track_event_signatures, windows

The search of the detection returns the same 15 rows over the two samples with either source, because the rule searches PowerShell script block event 4104 and only the first sample holds those events. So this change does not alter the result of the test.

I left the other checklist items open. The file changes only the tests source line and modification_date, and CI has not run yet.

Checklist

  • Validate name matches <platform>_<mitre att&ck technique>_<short description> nomenclature
  • CI/CD jobs passed ✔️
  • Validated SPL logic.
  • Validated tags, description, and how to implement.
  • Verified references match analytic.
  • Confirm updates to lookups are handled properly.

Notes For Submitters and Reviewers

  • If you're submitting a PR from a fork, ensuring the box to allow updates from maintainers is checked will help speed up the process of getting it merged.
  • Checking the output of the build CI job when it fails will likely show an error about what is failing. You may have a very descriptive error of the specific field(s) in the specific file(s) that is causing an issue. In some cases, its also possible there is an issue with the YAML. Many of these can be caught with the pre-commit hooks if you set them up. These errors will be less descriptive as to what exactly is wrong, but will give you a column and row position in a specific file where the YAML processing breaks. If you're having trouble with this, feel free to add a comment to your PR tagging one of the maintainers and we'll be happy to help troubleshoot it.
  • Updates to existing lookup files can be tricky, because of how Splunk handles application updates and the differences between existing lookup files being updated vs new lookups. You can read more here but the short version is that any changes to lookup files need to bump the the date and version in the associated YAML file.

…ery with PowerView to Security

The file holds Security events (event 5145), and attack_data declares it as
XmlWinEventLog:Security. The test declared it as Sysmon, so Splunk did not
tag it as Security data. Set the source and the modification date. The
version stays, because only the tests block changes.

Fixes splunk#4418
@nasbench
nasbench enabled auto-merge (squash) November 19, 2026 11:42
@nasbench
nasbench merged commit 9565205 into splunk:develop Nov 19, 2026
4 of 7 checks passed
@nasbench nasbench modified the milestones: v6.12.0, v6.11.1 Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Elevated Group Discovery with PowerView: the test sample windows-xml.log is declared as Sysmon but holds Security events

2 participants