Repository navigation
Fix the source of the windows-xml.log sample in Elevated Group Discovery with PowerView - #4430
Merged
Merged
Conversation
…ery with PowerView to Security The file holds Security events (event 5145), and attack_data declares it as XmlWinEventLog:Security. The test declared it as Sysmon, so Splunk did not tag it as Security data. Set the source and the modification date. The version stays, because only the tests block changes. Fixes splunk#4418
TT5H
requested review from
P4T12ICK,
RavenTait,
ljstella,
nasbench,
onurmerdogan,
patel-bhavin,
pyth0n1c,
rosplk and
tccontre
as code owners
November 16, 2026 20:56
nasbench
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4418.
Details
In the
testsblock ofdetections/endpoint/elevated_group_discovery_with_powerview.yml, the second samplewindows-xml.logis declared with the sourceXmlWinEventLog:Microsoft-Windows-Sysmon/Operational. The file holds 8 events, all Security event 5145 on theSecuritychannel, and the descriptorAD_discovery.ymlin attack_data declares it asXmlWinEventLog:Security.This changes the source of that sample to
XmlWinEventLog:Securityand setsmodification_date.versionstays at 11, because only thetestsblock changes. The atomic GUID mapping update (#4315) also set onlymodification_datefor edits outside the search.I ingested the second sample in Splunk Enterprise 9.3.14 (Splunk_SA_CIM 6.4.0, Splunk_TA_windows 9.1.2, Splunk_TA_microsoft_sysmon 5.0.0), once with each source:
XmlWinEventLog:Microsoft-Windows-Sysmon/Operational(current)endpoint_services_processes,windows_event_signature,windows_ta_datatrack_event_signaturesXmlWinEventLog:Security(this change)wineventlog_security,wineventlog_windows,winsecos,security,success,track_event_signatures,windowsThe search of the detection returns the same 15 rows over the two samples with either source, because the rule searches PowerShell script block event 4104 and only the first sample holds those events. So this change does not alter the result of the test.
I left the other checklist items open. The file changes only the
testssource line andmodification_date, and CI has not run yet.Checklist
<platform>_<mitre att&ck technique>_<short description>nomenclatureNotes For Submitters and Reviewers
buildCI job when it fails will likely show an error about what is failing. You may have a very descriptive error of the specific field(s) in the specific file(s) that is causing an issue. In some cases, its also possible there is an issue with the YAML. Many of these can be caught with the pre-commit hooks if you set them up. These errors will be less descriptive as to what exactly is wrong, but will give you a column and row position in a specific file where the YAML processing breaks. If you're having trouble with this, feel free to add a comment to your PR tagging one of the maintainers and we'll be happy to help troubleshoot it.