Repository navigation
Use GitHub's merge base for contract review comparisons - #43
Open
fontanierh wants to merge 1 commit into
Open
fontanierh wants to merge 1 commit into
fontanierh wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Git and GitHub can choose different starting points when comparing a PR. The bot can then try to comment on a line outside GitHub's diff, making the whole review fail with
422: Line could not be resolved.This change makes review setup and posting use GitHub's comparison of the saved commits. Findings that cannot be posted on a diff line stay in the review body, with links to the source.
Tests: