fix: support typographic quotes and zero-width spaces - #967
Open
cnbei wants to merge 2 commits into
Open
Conversation
Tokenize U+2018/U+2019 as string delimiters and treat U+200B as whitespace so copy-pasted Transact-SQL no longer fails to parse. Co-authored-by: cnbei <baymy@foxmail.com>
Co-authored-by: cnbei <baymy@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #942
U+200B is not JS whitespace, and typographic quotes U+2018/U+2019 were not string delimiters, so pasted Transact-SQL like the #942 playground snippet failed to tokenize.
Treat ZWSP as whitespace, accept paired curly single quotes as strings (not mixed with ASCII apostrophe), and add regression tests. 5907 Jest tests passed.