'fix(fetch_with_meta) :: return json bodies under the documented key - #1393
Open
81reap wants to merge 1 commit into
Open
'fix(fetch_with_meta) :: return json bodies under the documented key#139381reap wants to merge 1 commit into
81reap wants to merge 1 commit into
Conversation
lovasoa
requested changes
Aug 18, 2026
lovasoa
left a comment
lovasoa
left a comment
Collaborator
There was a problem hiding this comment.
I think it's better to avoid breaking existing applications, and avoid polymorphic response fields. Having a json field that can only contain json is easier to handle. But you are right that we should document it!
Contributor
Author
|
will follow up with a rev2! |
81reap
force-pushed
the
drift/3-fetch-with-meta
branch
from
August 20, 2026 00:57
c4492c1 to
20a342f
Compare
Contributor
Author
|
@lovasoa actually as I was making the change, I realized that documenting it as lmk your thoughts, I can still move forward with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses B3 in #1386
lmk if you would rather I go the other direction where we document
json_body. to me it seemed better to overload the knownbodykey