Repository navigation
fix: report success for merge queue groups - #4
Merged
Merged
Conversation
The organization ruleset requires this workflow, but it only ran on pull request events, so a repository with a merge queue waited forever for it on each merge group. Run on merge_group too and skip the job there: there is nothing to request, and the queue's own required checks decide the merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The organization ruleset requires Request Auto-Merge on every public repository, but the workflow only triggered on pull_request_target. In a repository with a merge queue (sqlbuild since today), each merge group waited for a check that never ran: sqlbuild#1419's group passed every repository check and still sat in AWAITING_CHECKS.
The workflow now also runs on merge_group. Its job is skipped there, so the workflow reports success and the queue's own required checks decide. Pull request behaviour is unchanged. The README notes it.
Checked with actionlint. The live test is the next sqlbuild merge group.