Repository navigation
fix: keep prefix NOT LIKE predicates typed - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A prefix
NOTon a LIKE-family predicate (WHERE NOT x LIKE 'a%') was parsed into a typed predicate and then deliberately replaced with an opaque Raw node in every dialect except TSQL/Fabric. Validation, linting and other AST consumers could not see inside it, so a SQL build tool silently skipped checks on such queries.Changes
Not(Like(...))/Not(ILike(...))for prefix NOT, including ANY/ALL/SOME quantifiers and ESCAPE; ClickHouse's higher-precedence NOT handling is unchanged.Verification